Merge branch 'master' of git://github.com/zigdon/twirssi

Conflicts:
	twirssi.pl

diff --git a/README b/README
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..bf6841badb35cab682bef8e496ef99826cc7da81 100644 (file)
--- a/README
+++ b/README
@@ -0,0 +1,25 @@
+### Required Modules ###
+You may need to use CPAN or another method to install these modules.
+    * WWW::Shorten::TinyURL
+    * Net::Twitter
+
+### Installation ###
+Installation is two part. First 
+
+In a terminal:
+
+    * Install a current version of Net::Twitter. Versions earlier than 3.0 are not supported.
+    * Create a directory for irssi scripts, if it doesn't already exist: mkdir ~/.irssi/scripts
+    * Change to that directory: cd ~/.irssi/scripts
+    * Remove any old version of the script: rm twirssi.pl
+    * Download the latest version: wget http://twirssi.com/twirssi.pl
+    * If you want it to automatically load with irssi, create an autorun dir: mkdir autorun
+    * And create a symlink in it: ln -s ../twirssi.pl autorun
+
+In irssi:
+
+    * If you don't already have a twitter window, create a new window: /win new hidden
+    * Name the new window: /win name twitter
+    * In that window type: /script load twirssi.pl
+    * Login: /twitter_login username password
+

diff --git a/twirssi.pl b/twirssi.pl
index 45faf6fe4e3c2e38b7342e7f3e82c0bac5b4e504..7099013f64cd8f1841c114cdb1e09855cc170a91 100644 (file)
--- a/twirssi.pl
+++ b/twirssi.pl
@@ -13,7 +13,7 @@ $Data::Dumper::Indent = 1;
 
 use vars qw($VERSION %IRSSI);
 
-$VERSION = "2.4.1beta";
+$VERSION = "2.4.2";
 %IRSSI   = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
@@ -131,11 +131,6 @@ sub cmd_retweet {
 sub cmd_retweet_as {
     my ( $data, $server, $win ) = @_;
 
-    unless ( Irssi::settings_get_bool("twirssi_track_replies") ) {
-        &notice("twirssi_track_replies is required in order to reteet.");
-        return;
-    }
-
     return unless &logged_in($twit);
 
     $data =~ s/^\s+|\s+$//;
@@ -296,13 +291,6 @@ sub cmd_reply {
 sub cmd_reply_as {
     my ( $data, $server, $win ) = @_;
 
-    unless ( Irssi::settings_get_bool("twirssi_track_replies") ) {
-        &notice("twirssi_track_replies is required in order to reply to "
-              . "specific tweets.  Either enable it, or just use /tweet "
-              . "\@username <text>." );
-        return;
-    }
-
     return unless &logged_in($twit);
 
     $data =~ s/^\s+|\s+$//;
@@ -513,7 +501,6 @@ sub cmd_login {
         username => $user,
         password => $pass,
     );
-
     unless ($twit) {
         &notice("Failed to create object!  Aborting.");
         return;
@@ -626,7 +613,7 @@ sub verify_twitter_object {
     $poll = Irssi::timeout_add( &get_poll_time * 1000, \&get_updates, "" );
     &notice("Logged in as $user\@$service, loading friends list...");
     &load_friends();
-    &notice( "loaded friends: ". scalar keys %friends );
+    &notice( "loaded friends: " . scalar keys %friends );
     if ( Irssi::settings_get_bool("twirssi_first_run") ) {
         Irssi::settings_set_bool( "twirssi_first_run", 0 );
     }
@@ -927,7 +914,7 @@ sub get_updates {
     return unless &logged_in($twit);
 
     my ( $fh, $filename ) = File::Temp::tempfile();
-    binmode( $fh, ":utf8" );
+    binmode( $fh, ":" . &get_charset );
     $child_pid = fork();
 
     if ($child_pid) {    # parent
@@ -1041,9 +1028,31 @@ sub do_updates {
         return undef;
     }
 
+    my @ignore_tags =
+      Irssi::settings_get_str("twirssi_ignored_tags")
+      ? split /\s*,\s*/, Irssi::settings_get_str("twirssi_ignored_tags")
+      : ();
+    my @strip_tags =
+      Irssi::settings_get_str("twirssi_stripped_tags")
+      ? split /\s*,\s*/, Irssi::settings_get_str("twirssi_stripped_tags")
+      : ();
     foreach my $t ( reverse @$tweets ) {
         my $text = &get_text( $t, $obj );
         my $reply = "tweet";
+
+        my $match = 0;
+        foreach my $tag (@ignore_tags) {
+            next unless $text =~ /\b\Q$tag\E\b/i;
+            $match = 1;
+            $text = "(ignored: $tag) $text" if &debug;
+            last;
+        }
+        next if not &debug and $match;
+
+        foreach my $tag (@strip_tags) {
+            $text =~ s/\b\Q$tag\E\b//gi;
+        }
+
         if (    Irssi::settings_get_bool("show_reply_context")
             and $t->{in_reply_to_screen_name} ne $username
             and $t->{in_reply_to_screen_name}
@@ -1164,6 +1173,7 @@ sub do_updates {
             }
 
             $id_map{__searches}{$username}{$topic} = $search->{max_id};
+            $topic =~ s/ /%20/g;
             printf $fh "id:%s account:%s type:searchid topic:%s\n",
               $search->{max_id}, $username, $topic;
 
@@ -1266,7 +1276,7 @@ sub monitor_child {
     # pretend
 
     if ( open FILE, $filename ) {
-        binmode FILE, ":utf8";
+        binmode FILE, ":" . &get_charset;
         my @lines;
         my %new_cache;
         while (<FILE>) {
@@ -1280,8 +1290,9 @@ sub monitor_child {
             my %meta;
 
             foreach my $key (qw/id account nick type topic/) {
-                if (s/^$key:(\S+)\s*//) {
+                if (s/^$key:((?:\S|\\ )+)\s*//) {
                     $meta{$key} = $1;
+                    $meta{$key} =~ s/%20/ /g;
                 }
             }
 
@@ -1319,11 +1330,7 @@ sub monitor_child {
             }
 
             my $marker = "";
-            if (    $meta{type} ne 'dm'
-                and Irssi::settings_get_bool("twirssi_track_replies")
-                and $meta{nick}
-                and $meta{id} )
-            {
+            if ( $meta{type} ne 'dm' and $meta{nick} and $meta{id} ) {
                 $marker = ( $id_map{__indexes}{ $meta{nick} } + 1 ) % 100;
                 $id_map{ lc $meta{nick} }[$marker]           = $meta{id};
                 $id_map{__indexes}{ $meta{nick} }            = $marker;
@@ -1460,7 +1467,7 @@ sub monitor_child {
             Irssi::pidwait_remove($child_pid);
 
             # and that we don't leave any zombies behind, somehow
-            wait();
+            waitpid( -1, WNOHANG );
 
             # save id_map hash
             if ( keys %id_map
@@ -1488,7 +1495,7 @@ sub monitor_child {
     } else {
         print "Giving up on polling $filename" if &debug;
         Irssi::pidwait_remove($child_pid);
-        wait();
+        waitpid( -1, WNOHANG );
         unlink $filename unless &debug;
 
         return unless Irssi::settings_get_bool("twirssi_notify_timeouts");
@@ -1511,7 +1518,7 @@ sub monitor_child {
                 q{      \\          a    |},
                 q{       ',.__.   ,__.-'/},
                 q{         '--/_.'----'`}
-              );
+            );
             $failwhale = 1;
         }
 
@@ -1650,6 +1657,12 @@ sub get_poll_time {
     return 60;
 }
 
+sub get_charset {
+    my $charset = Irssi::settings_get_str("twirssi_charset");
+    return "utf8" if $charset =~ /^\s*$/;
+    return $charset;
+}
+
 sub hilight {
     my $text = shift;
 
@@ -1690,7 +1703,7 @@ sub shorten {
                     "Set short_url_args to username,API_key or change your",
                     "short_url_provider."
                 );
-                return decode "utf8", $data;
+                return decode &get_charset, $data;
             }
         }
 
@@ -1707,7 +1720,7 @@ sub shorten {
         }
     }
 
-    return decode "utf8", $data;
+    return decode &get_charset, $data;
 }
 
 sub normalize_username {
@@ -1768,6 +1781,7 @@ Irssi::theme_register(
 );
 
 Irssi::settings_add_int( "twirssi", "twitter_poll_interval", 300 );
+Irssi::settings_add_str( "twirssi", "twirssi_charset",         "utf8" );
 Irssi::settings_add_str( "twirssi", "twitter_window",          "twitter" );
 Irssi::settings_add_str( "twirssi", "bitlbee_server",          "bitlbee" );
 Irssi::settings_add_str( "twirssi", "short_url_provider",      "TinyURL" );
@@ -1777,6 +1791,8 @@ Irssi::settings_add_str( "twirssi", "twitter_passwords",       undef );
 Irssi::settings_add_str( "twirssi", "twirssi_default_service", "Twitter" );
 Irssi::settings_add_str( "twirssi", "twirssi_nick_color",      "%B" );
 Irssi::settings_add_str( "twirssi", "twirssi_topic_color",     "%r" );
+Irssi::settings_add_str( "twirssi", "twirssi_ignored_tags",    "" );
+Irssi::settings_add_str( "twirssi", "twirssi_stripped_tags",   "" );
 Irssi::settings_add_str( "twirssi", "twirssi_retweet_format",
     'RT $n: "$t" ${-- $c$}' );
 Irssi::settings_add_str( "twirssi", "twirssi_location",
@@ -1795,7 +1811,6 @@ Irssi::settings_add_bool( "twirssi", "show_reply_context",        0 );
 Irssi::settings_add_bool( "twirssi", "show_own_tweets",           1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_debug",             0 );
 Irssi::settings_add_bool( "twirssi", "twirssi_first_run",         1 );
-Irssi::settings_add_bool( "twirssi", "twirssi_track_replies",     1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_replies_autonick",  1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_use_reply_aliases", 0 );
 Irssi::settings_add_bool( "twirssi", "twirssi_notify_timeouts",   1 );
@@ -1924,9 +1939,11 @@ if ($window) {
     );
     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 
-    &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N",
-            "   %C(_(\\%N           http://twirssi.com/ for full docs",
-            "    %Y||%C `%N Log in with /twitter_login, send updates with /tweet");
+    &notice(
+        "  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N",
+        "   %C(_(\\%N           http://twirssi.com/ for full docs",
+        "    %Y||%C `%N Log in with /twitter_login, send updates with /tweet"
+    );
 
     my $file = Irssi::settings_get_str("twirssi_replies_store");
     if ( $file and -r $file ) {