Prevent read_openpgp_stream from returning empty packets

[onak.git] / onak.c

diff --git a/onak.c b/onak.c
index 2da86c915cae8708a192c7f0668cda6bc6eb6076..6baea3debb96715cfd16350480eed24dc57cd119 100644 (file)
--- a/onak.c
+++ b/onak.c
@@ -3,20 +3,35 @@
  *
  * This is the main swiss army knife binary.
  *
  *
  * This is the main swiss army knife binary.
  *

- * Jonathan McDowell <noodles@earth.li>
- * 
- * Copyright 2002 Project Purple
+ * Copyright 2002 Jonathan McDowell <noodles@earth.li>

  *
  *

- * $Id: onak.c,v 1.17 2003/09/30 20:40:11 noodles Exp $
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program; if not, write to the Free Software Foundation, Inc., 51
+ * Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

  */
 
  */
 

+#include <fcntl.h>
+#include <getopt.h>

 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

+#include <sys/types.h>
+#include <sys/stat.h>

 #include <unistd.h>
 
 #include "armor.h"
 #include "charfuncs.h"
 #include <unistd.h>
 
 #include "armor.h"
 #include "charfuncs.h"

+#include "cleankey.h"
+#include "cleanup.h"

 #include "keydb.h"
 #include "keyid.h"
 #include "keyindex.h"
 #include "keydb.h"
 #include "keyid.h"
 #include "keyindex.h"


@@ -26,20 +41,22 @@
 #include "merge.h"
 #include "onak-conf.h"
 #include "parsekey.h"
 #include "merge.h"
 #include "onak-conf.h"
 #include "parsekey.h"

+#include "photoid.h"
+#include "version.h"

 
 void find_keys(char *search, uint64_t keyid, bool ishex,
 
 void find_keys(char *search, uint64_t keyid, bool ishex,

-               bool fingerprint, bool exact, bool verbose)
+               bool fingerprint, bool skshash, bool exact, bool verbose)

 {
        struct openpgp_publickey *publickey = NULL;
        int count = 0;
 
        if (ishex) {
 {
        struct openpgp_publickey *publickey = NULL;
        int count = 0;
 
        if (ishex) {

-               count = fetch_key(keyid, &publickey, false);
+               count = config.dbbackend->fetch_key(keyid, &publickey, false);

        } else {
        } else {

-               count = fetch_key_text(search, &publickey);
+               count = config.dbbackend->fetch_key_text(search, &publickey);

        }
        if (publickey != NULL) {
        }
        if (publickey != NULL) {

-               key_index(publickey, verbose, fingerprint, false);
+               key_index(publickey, verbose, fingerprint, skshash, false);

                free_publickey(publickey);
        } else if (count == 0) {
                puts("Key not found.");
                free_publickey(publickey);
        } else if (count == 0) {
                puts("Key not found.");


@@ -51,19 +68,67 @@ void find_keys(char *search, uint64_t keyid, bool ishex,
        }
 }
 
        }
 }
 

+/**
+ * @brief Context for the keyserver dumping function
+ */
+struct dump_ctx {
+       /** Keys we've dumped so far to this file */
+       int count;
+       /** Maximum keys to dump per file */
+       int maxcount;
+       /** File descriptor for the current dump file */
+       int fd;
+       /** Number of the current dump file */
+       int filenum;
+       /** Base filename to use for dump files */
+       char *filebase;
+};
+
+void dump_func(void *ctx, struct openpgp_publickey *key)
+{
+       struct openpgp_packet_list *packets = NULL;
+       struct openpgp_packet_list *list_end = NULL;
+       struct dump_ctx *state;
+       char filename[1024];
+
+       state = (struct dump_ctx *) ctx;
+
+       if (state->fd == -1 || state->count++ > state->maxcount) {
+               if (state->fd != -1) {
+                       close(state->fd);
+                       state->fd = -1;
+               }
+               snprintf(filename, 1023, state->filebase, state->filenum);
+               state->fd = open(filename, O_CREAT | O_WRONLY | O_TRUNC, 0640);
+               state->filenum++;
+               state->count = 0;
+       }
+       flatten_publickey(key, &packets, &list_end);
+       write_openpgp_stream(file_putchar, &state->fd, packets);
+       free_packet_list(packets);
+       packets = list_end = NULL;
+
+       return;
+}
+

 void usage(void) {
 void usage(void) {

-       puts("onak " VERSION " - an OpenPGP keyserver.\n");
+       puts("onak " ONAK_VERSION " - an OpenPGP keyserver.\n");

        puts("Usage:\n");
        puts("\tonak [options] <command> <parameters>\n");
        puts("\tCommands:\n");
        puts("Usage:\n");
        puts("\tonak [options] <command> <parameters>\n");
        puts("\tCommands:\n");

-       puts("\tadd    - read armored OpenPGP keys from stdin and add to the"
+       puts("\tadd      - read armored OpenPGP keys from stdin and add to the"

                " keyserver");
                " keyserver");

-       puts("\tdelete - delete a given key from the keyserver");
-       puts("\tdump   - dump all the keys from the keyserver to a file or"
-               " files\n\t         starting keydump*");
-       puts("\tget    - retrieves the key requested from the keyserver");
-       puts("\tindex  - search for a key and list it");
-       puts("\tvindex - search for a key and list it and its signatures");
+       puts("\tclean    - read armored OpenPGP keys from stdin, run the"
+               " cleaning\n\t             routines against them and dump to"
+               " stdout");
+       puts("\tdelete   - delete a given key from the keyserver");
+       puts("\tdump     - dump all the keys from the keyserver to a file or"
+               " files\n\t           starting keydump*");
+       puts("\tget      - retrieves the key requested from the keyserver");
+       puts("\tgetphoto - retrieves the first photoid on the given key and"
+               " dumps to\n\t           stdout");
+       puts("\tindex    - search for a key and list it");
+       puts("\tvindex   - search for a key and list it and its signatures");

 }
 
 int main(int argc, char *argv[])
 }
 
 int main(int argc, char *argv[])


@@ -71,6 +136,7 @@ int main(int argc, char *argv[])
        struct openpgp_packet_list      *packets = NULL;
        struct openpgp_packet_list      *list_end = NULL;
        struct openpgp_publickey        *keys = NULL;
        struct openpgp_packet_list      *packets = NULL;
        struct openpgp_packet_list      *list_end = NULL;
        struct openpgp_publickey        *keys = NULL;

+       char                            *configfile = NULL;

        int                              rc = EXIT_SUCCESS;
        int                              result = 0;
        char                            *search = NULL;
        int                              rc = EXIT_SUCCESS;
        int                              result = 0;
        char                            *search = NULL;


@@ -81,16 +147,25 @@ int main(int argc, char *argv[])
        bool                             update = false;
        bool                             binary = false;
        bool                             fingerprint = false;
        bool                             update = false;
        bool                             binary = false;
        bool                             fingerprint = false;

+       bool                             skshash = false;

        int                              optchar;
        int                              optchar;

+       struct dump_ctx                  dumpstate;
+       struct skshash                   hash;

 
 

-       while ((optchar = getopt(argc, argv, "bfuv")) != -1 ) {
+       while ((optchar = getopt(argc, argv, "bc:fsuv")) != -1 ) {

                switch (optchar) {
                case 'b': 
                        binary = true;
                        break;
                switch (optchar) {
                case 'b': 
                        binary = true;
                        break;

+               case 'c':
+                       configfile = strdup(optarg);
+                       break;

                case 'f': 
                        fingerprint = true;
                        break;
                case 'f': 
                        fingerprint = true;
                        break;

+               case 's': 
+                       skshash = true;
+                       break;

                case 'u': 
                        update = true;
                        break;
                case 'u': 
                        update = true;
                        break;


@@ -101,15 +176,24 @@ int main(int argc, char *argv[])
                }
        }
 
                }
        }
 

-       readconfig();
+       readconfig(configfile);

        initlogthing("onak", config.logfile);
        initlogthing("onak", config.logfile);

+       catchsignals();

 
        if ((argc - optind) < 1) {
                usage();
        } else if (!strcmp("dump", argv[optind])) {
 
        if ((argc - optind) < 1) {
                usage();
        } else if (!strcmp("dump", argv[optind])) {

-               initdb();
-               dumpdb("keydump");
-               cleanupdb();
+               config.dbbackend->initdb(true);
+               dumpstate.count = dumpstate.filenum = 0;
+               dumpstate.maxcount = 100000;
+               dumpstate.fd = -1;
+               dumpstate.filebase = "keydump.%d.pgp";
+               config.dbbackend->iterate_keys(dump_func, &dumpstate);
+               if (dumpstate.fd != -1) {
+                       close(dumpstate.fd);
+                       dumpstate.fd = -1;
+               }
+               config.dbbackend->cleanupdb();

        } else if (!strcmp("add", argv[optind])) {
                if (binary) {
                        result = read_openpgp_stream(stdin_getchar, NULL,
        } else if (!strcmp("add", argv[optind])) {
                if (binary) {
                        result = read_openpgp_stream(stdin_getchar, NULL,


@@ -126,20 +210,31 @@ int main(int argc, char *argv[])
                        logthing(LOGTHING_INFO, "Finished reading %d keys.",
                                        result);
 
                        logthing(LOGTHING_INFO, "Finished reading %d keys.",
                                        result);
 

-                       initdb();
+                       result = cleankeys(keys);
+                       logthing(LOGTHING_INFO, "%d keys cleaned.",
+                                       result);
+
+                       config.dbbackend->initdb(false);

                        logthing(LOGTHING_NOTICE, "Got %d new keys.",
                        logthing(LOGTHING_NOTICE, "Got %d new keys.",

-                                       update_keys(&keys));
+                                       config.dbbackend->update_keys(&keys,
+                                       false));

                        if (keys != NULL && update) {
                                flatten_publickey(keys,
                                        &packets,
                                        &list_end);
                        if (keys != NULL && update) {
                                flatten_publickey(keys,
                                        &packets,
                                        &list_end);

-                               armor_openpgp_stream(stdout_putchar,
-                                       NULL,
-                                       packets);
+                               if (binary) {
+                                       write_openpgp_stream(stdout_putchar,
+                                                       NULL,
+                                                       packets);
+                               } else {
+                                       armor_openpgp_stream(stdout_putchar,
+                                               NULL,
+                                               packets);
+                               }

                                free_packet_list(packets);
                                packets = NULL;
                        }
                                free_packet_list(packets);
                                packets = NULL;
                        }

-                       cleanupdb();
+                       config.dbbackend->cleanupdb();

                } else {
                        rc = 1;
                        logthing(LOGTHING_NOTICE, "No keys read.");
                } else {
                        rc = 1;
                        logthing(LOGTHING_NOTICE, "No keys read.");


@@ -152,9 +247,66 @@ int main(int argc, char *argv[])
                        rc = 1;
                        logthing(LOGTHING_NOTICE, "No changes.");
                }
                        rc = 1;
                        logthing(LOGTHING_NOTICE, "No changes.");
                }

+       } else if (!strcmp("clean", argv[optind])) {
+               if (binary) {
+                       result = read_openpgp_stream(stdin_getchar, NULL,
+                                &packets, 0);
+                       logthing(LOGTHING_INFO,
+                                       "read_openpgp_stream: %d", result);
+               } else {
+                       dearmor_openpgp_stream(stdin_getchar, NULL, &packets);
+               }
+
+               if (packets != NULL) {
+                       result = parse_keys(packets, &keys);
+                       free_packet_list(packets);
+                       packets = NULL;
+                       logthing(LOGTHING_INFO, "Finished reading %d keys.",
+                                       result);
+
+                       if (keys != NULL) {
+                               result = cleankeys(keys);
+                               logthing(LOGTHING_INFO, "%d keys cleaned.",
+                                               result);
+
+                               flatten_publickey(keys,
+                                       &packets,
+                                       &list_end);
+
+                               if (binary) {
+                                       write_openpgp_stream(stdout_putchar,
+                                                       NULL,
+                                                       packets);
+                               } else {
+                                       armor_openpgp_stream(stdout_putchar,
+                                               NULL,
+                                               packets);
+                               }
+                               free_packet_list(packets);
+                               packets = NULL;
+                       }
+               } else {
+                       rc = 1;
+                       logthing(LOGTHING_NOTICE, "No keys read.");
+               }
+               
+               if (keys != NULL) {
+                       free_publickey(keys);
+                       keys = NULL;
+               }

        } else if ((argc - optind) == 2) {
                search = argv[optind+1];
        } else if ((argc - optind) == 2) {
                search = argv[optind+1];

-               if (search != NULL) {
+               if (search != NULL && strlen(search) == 42 &&
+                               search[0] == '0' && search[1] == 'x') {
+                       /*
+                        * Fingerprint. Truncate to last 64 bits for
+                        * now.
+                        */
+                       keyid = strtoull(&search[26], &end, 16);
+                       if (end != NULL && *end == 0) {
+                               ishex = true;
+                       }
+               } else if (search != NULL) {

                        keyid = strtoul(search, &end, 16);
                        if (*search != 0 &&
                                        end != NULL &&
                        keyid = strtoul(search, &end, 16);
                        if (*search != 0 &&
                                        end != NULL &&


@@ -162,35 +314,89 @@ int main(int argc, char *argv[])
                                ishex = true;
                        }
                }
                                ishex = true;
                        }
                }

-               initdb();
+               config.dbbackend->initdb(false);

                if (!strcmp("index", argv[optind])) {
                if (!strcmp("index", argv[optind])) {

-                       find_keys(search, keyid, ishex, fingerprint,
+                       find_keys(search, keyid, ishex, fingerprint, skshash,

                                        false, false);
                } else if (!strcmp("vindex", argv[optind])) {
                                        false, false);
                } else if (!strcmp("vindex", argv[optind])) {

-                       find_keys(search, keyid, ishex, fingerprint,
+                       find_keys(search, keyid, ishex, fingerprint, skshash,

                                        false, true);
                                        false, true);

+               } else if (!strcmp("getphoto", argv[optind])) {
+                       if (!ishex) {
+                               puts("Can't get a key on uid text."
+                                       " You must supply a keyid.");
+                       } else if (config.dbbackend->fetch_key(keyid, &keys,
+                                       false)) {
+                               unsigned char *photo = NULL;
+                               size_t         length = 0;
+
+                               if (getphoto(keys, 0, &photo,
+                                               &length) == ONAK_E_OK) {
+                                       fwrite(photo,
+                                               1,
+                                               length,
+                                               stdout);
+                               }
+                               free_publickey(keys);
+                               keys = NULL;
+                       } else {
+                               puts("Key not found");
+                       }

                } else if (!strcmp("delete", argv[optind])) {
                } else if (!strcmp("delete", argv[optind])) {

-                       delete_key(getfullkeyid(keyid), false);
+                       config.dbbackend->delete_key(
+                                       config.dbbackend->getfullkeyid(keyid),
+                                       false);

                } else if (!strcmp("get", argv[optind])) {
                        if (!ishex) {
                                puts("Can't get a key on uid text."
                                        " You must supply a keyid.");
                } else if (!strcmp("get", argv[optind])) {
                        if (!ishex) {
                                puts("Can't get a key on uid text."
                                        " You must supply a keyid.");

-                       } else if (fetch_key(keyid, &keys, false)) {
+                       } else if (config.dbbackend->fetch_key(keyid, &keys,
+                                       false)) {

                                logthing(LOGTHING_INFO, "Got key.");
                                flatten_publickey(keys,
                                                &packets,
                                                &list_end);
                                free_publickey(keys);
                                logthing(LOGTHING_INFO, "Got key.");
                                flatten_publickey(keys,
                                                &packets,
                                                &list_end);
                                free_publickey(keys);

-                               armor_openpgp_stream(stdout_putchar,
+                               if (binary) {
+                                       write_openpgp_stream(stdout_putchar,
+                                               NULL,
+                                               packets);
+                               } else {
+                                       armor_openpgp_stream(stdout_putchar,
+                                               NULL,
+                                               packets);
+                               }
+                               free_packet_list(packets);
+                               packets = NULL;
+                       } else {
+                               puts("Key not found");
+                       }
+               } else if (!strcmp("hget", argv[optind])) {
+                       if (!parse_skshash(search, &hash)) {
+                               puts("Couldn't parse sks hash.");
+                       } else if (config.dbbackend->fetch_key_skshash(&hash,
+                                       &keys)) {
+                               logthing(LOGTHING_INFO, "Got key.");
+                               flatten_publickey(keys,
+                                               &packets,
+                                               &list_end);
+                               free_publickey(keys);
+                               if (binary) {
+                                       write_openpgp_stream(stdout_putchar,
+                                               NULL,
+                                               packets);
+                               } else {
+                                       armor_openpgp_stream(stdout_putchar,

                                                NULL,
                                                packets);
                                                NULL,
                                                packets);

+                               }

                                free_packet_list(packets);
                                packets = NULL;
                        } else {
                                puts("Key not found");
                        }
                }
                                free_packet_list(packets);
                                packets = NULL;
                        } else {
                                puts("Key not found");
                        }
                }

-               cleanupdb();
+               config.dbbackend->cleanupdb();

        } else {
                usage();
        }
        } else {
                usage();
        }