* Jonathan McDowell <noodles@earth.li>
*
* Copyright 2002 Project Purple
- *
- * $Id: parsekey.c,v 1.14 2003/09/30 21:59:33 noodles Exp $
*/
-#include <assert.h>
#include <stdbool.h>
#include <stdio.h>
#include <stdlib.h>
#include "mem.h"
#include "parsekey.h"
-/**
- * add_key - Takes a key and adds it to the keyserver.
- * @key: The public key to add.
- *
- * This function takes a public key and adds it to the keyserver.
- * It first of all sees if we already have the key locally. If we do then
- * we retrieve it and merge the two keys. We then store the resulting key
- * (or just the original we received if we don't already have it). We then
- * send out the appropriate updates to our keyserver peers.
- */
-int add_key(struct openpgp_publickey *key) {
- return 0;
-}
-
/**
* parse_keys - Process a stream of packets for public keys + sigs.
* @packets: The packet list to parse.
case 2:
/*
* It's a signature packet. Add it to either the public
- * key (it should be a revocation), to the current UID
- * or the current subkey.
+ * key, to the current UID or the current subkey.
*/
- assert(curkey != NULL);
+ log_assert(curkey != NULL);
if (curkey->subkeys != NULL) {
ADD_PACKET_TO_LIST_END(curkey->last_subkey,
sig,
packet_dup(packets->packet));
} else {
ADD_PACKET_TO_LIST_END(curkey,
- revocation,
+ sig,
packet_dup(packets->packet));
+ /*
+ * This is a signature on the public key; check
+ * if it's a revocation.
+ */
+ if (packets->packet->data[0] == 3 &&
+ packets->packet->data[2] == 0x20) {
+ /*
+ * Type 3 key, 0x20 == revocation
+ */
+ curkey->revoked = true;
+ } else if (packets->packet->data[0] == 4 &&
+ packets->packet->data[1] == 0x20) {
+ /*
+ * Type 4 key, 0x20 == revocation
+ */
+ curkey->revoked = true;
+ }
}
break;
case 6:
/*
* It's a UID packet (or a photo id, which is similar).
*/
- assert(curkey != NULL);
- assert(curkey->subkeys == NULL);
+ log_assert(curkey != NULL);
+ log_assert(curkey->subkeys == NULL);
ADD_PACKET_TO_LIST_END(curkey,
uid,
packet_dup(packets->packet));
/*
* It's a subkey packet.
*/
- assert(curkey != NULL);
+ log_assert(curkey != NULL);
ADD_PACKET_TO_LIST_END(curkey,
subkey,
packet_dup(packets->packet));
*/
int debug_packet(struct openpgp_packet *packet)
{
- printf("\tNew format: %d, Tag: %d, Length: %d\n",
+ printf("\tNew format: %d, Tag: %u, Length: %zd\n",
packet->newformat,
packet->tag,
packet->length);
* ready for parsing as a public key or whatever.
*/
int read_openpgp_stream(int (*getchar_func)(void *ctx, size_t count,
- unsigned char *c),
+ void *c),
void *ctx,
struct openpgp_packet_list **packets,
int maxnum)
{
unsigned char curchar = 0;
- unsigned long count = 0;
struct openpgp_packet_list *curpacket = NULL;
int rc = 0;
int keys = 0;
bool inpacket = false;
- assert(packets != NULL);
+ log_assert(packets != NULL);
curpacket = *packets;
if (curpacket != NULL) {
while (curpacket->next != NULL) {
}
}
- while (!rc && !getchar_func(ctx, 1, &curchar) &&
- (maxnum == 0 || keys < maxnum)) {
+ while (!rc && (maxnum == 0 || keys < maxnum) &&
+ !getchar_func(ctx, 1, &curchar)) {
if (!inpacket && (curchar & 0x80)) {
/*
* New packet. Record the fact we're in a packet and
* allocate memory for it.
*/
inpacket = true;
- count = 0;
if (curpacket != NULL) {
curpacket->next = malloc(sizeof (*curpacket));
curpacket = curpacket->next;
curpacket->packet->length = curchar;
curpacket->packet->length <<= 8;
rc = getchar_func(ctx, 1, &curchar);
- curpacket->packet->length = curchar;
+ curpacket->packet->length += curchar;
curpacket->packet->length <<= 8;
rc = getchar_func(ctx, 1, &curchar);
- curpacket->packet->length = curchar;
+ curpacket->packet->length += curchar;
curpacket->packet->length <<= 8;
rc = getchar_func(ctx, 1, &curchar);
- curpacket->packet->length = curchar;
+ curpacket->packet->length += curchar;
}
} else {
curpacket->packet->tag = (curchar & 0x3C) >> 2;
} else {
logthing(LOGTHING_ERROR, "Unexpected character: 0x%X",
curchar);
+ rc = 1;
}
}
* packet stream from a linked list of packets.
*/
int write_openpgp_stream(int (*putchar_func)(void *ctx, size_t count,
- unsigned char *c),
+ void *c),
void *ctx,
struct openpgp_packet_list *packets)
{
curchar = (packets->packet->length - 192) &
0xFF;
putchar_func(ctx, 1, &curchar);
+ } else if (packets->packet->length > 8382 &&
+ packets->packet->length < 0xFFFFFFFF) {
+ logthing(LOGTHING_DEBUG,
+ "Writing 5 byte length");
+ curchar = 255;
+ putchar_func(ctx, 1, &curchar);
+
+ curchar = (packets->packet->length >> 24);
+ curchar &= 0xFF;
+ putchar_func(ctx, 1, &curchar);
+
+ curchar = (packets->packet->length >> 16);
+ curchar &= 0xFF;
+ putchar_func(ctx, 1, &curchar);
+
+ curchar = (packets->packet->length >> 8);
+ curchar &= 0xFF;
+ putchar_func(ctx, 1, &curchar);
+
+ curchar = packets->packet->length;
+ curchar &= 0xFF;
+ putchar_func(ctx, 1, &curchar);
} else {
logthing(LOGTHING_ERROR,
"Unsupported new format length.");
}
/*
- * Now do any revocation signatures on the main key.
+ * Now do any signatures on the main key.
*/
- for (tmplist = key->revocations; tmplist != NULL;
+ for (tmplist = key->sigs; tmplist != NULL;
tmplist = tmplist->next) {
ADD_PACKET_TO_LIST((*list_end),
packet_dup(tmplist->packet));