From c119e650820fc03f4ffa5d6ecfe5c1a1332bd7d5 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sat, 7 Mar 2009 14:09:30 -0800 Subject: [PATCH 01/16] r523 - release v2.1.2 --- twirssi.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 44fae63..3cb6df8 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,8 +11,8 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); -$VERSION = "2.1.2beta"; -my ($REV) = '$Rev: 522 $' =~ /(\d+)/; +$VERSION = "2.1.2"; +my ($REV) = '$Rev: 523 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -21,7 +21,7 @@ my ($REV) = '$Rev: 522 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-07 14:07:25 -0800 (Sat, 07 Mar 2009) $', + changed => '$Date: 2009-03-07 14:09:03 -0800 (Sat, 07 Mar 2009) $', ); my $window; -- 2.39.5 From 62ffee79c45cc75e65d88a23cc281623973007fa Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Fri, 13 Mar 2009 10:37:50 -0700 Subject: [PATCH 02/16] r546 - Add support for Bit.ly as a valid shortner (new setting short_url_args). Clean up shortner code --- twirssi.pl | 76 +++++++++++++++++++++++++++++++++--------------------- 1 file changed, 46 insertions(+), 30 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 3cb6df8..a61ed0b 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,8 +11,8 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); -$VERSION = "2.1.2"; -my ($REV) = '$Rev: 523 $' =~ /(\d+)/; +$VERSION = "2.1.3beta"; +my ($REV) = '$Rev: 546 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -21,7 +21,7 @@ my ($REV) = '$Rev: 523 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-07 14:09:03 -0800 (Sat, 07 Mar 2009) $', + changed => '$Date: 2009-03-13 10:37:30 -0700 (Fri, 13 Mar 2009) $', ); my $window; @@ -134,16 +134,7 @@ sub cmd_tweet_as { return unless &valid_username($username); - if ( &too_long( $data, 1 ) - and Irssi::settings_get_str("short_url_provider") ) - { - foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) { - eval { - my $short = makeashorterlink($url); - $data =~ s/\Q$url/$short/g; - }; - } - } + $data = &shorten($data); return if &too_long($data); @@ -235,16 +226,7 @@ sub cmd_reply_as { $data = "\@$nick " . $data; } - if ( &too_long( $data, 1 ) ) { - if ( Irssi::settings_get_str("short_url_provider") ) { - foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) { - eval { - my $short = makeashorterlink($url); - $data =~ s/\Q$url/$short/g; - }; - } - } - } + $data = &shorten($data); return if &too_long($data); @@ -1217,6 +1199,39 @@ sub hilight { return $text; } +sub shorten { + my $data = shift; + + my $provider = Irssi::settings_get_str("short_url_provider"); + if ( &too_long( $data, 1 ) and $provider ) + { + my @args; + if ($provider eq 'Bitly') { + @args[1,2] = split ',', Irssi::settings_get_str("short_url_args"), 2; + unless (@args == 3) { + &ccrap("WWW::Shorten::Bitly requires a username and API key.", + "Set short_url_args to username,API_key or change your", + "short_url_provider."); + return $data; + } + } + + foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) { + eval { + $args[0] = $url; + my $short = makeashorterlink(@args); + if ($short) { + $data =~ s/\Q$url/$short/g; + } else { + ¬ice("Failed to shorten $url!"); + } + }; + } + } + + return $data; +} + Irssi::signal_add( "send text", "event_send_text" ); Irssi::theme_register( @@ -1233,14 +1248,15 @@ Irssi::settings_add_int( "twirssi", "twitter_poll_interval", 300 ); Irssi::settings_add_str( "twirssi", "twitter_window", "twitter" ); Irssi::settings_add_str( "twirssi", "bitlbee_server", "bitlbee" ); Irssi::settings_add_str( "twirssi", "short_url_provider", "TinyURL" ); -Irssi::settings_add_str( "twirssi", "twirssi_location", - ".irssi/scripts/twirssi.pl" ); +Irssi::settings_add_str( "twirssi", "short_url_args", undef ); Irssi::settings_add_str( "twirssi", "twitter_usernames", undef ); Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); -Irssi::settings_add_str( "twirssi", "twirssi_replies_store", - ".irssi/scripts/twirssi.json" ); Irssi::settings_add_str( "twirssi", "twirssi_nick_color", "%B" ); Irssi::settings_add_str( "twirssi", "twirssi_topic_color", "%r" ); +Irssi::settings_add_str( "twirssi", "twirssi_location", + ".irssi/scripts/twirssi.pl" ); +Irssi::settings_add_str( "twirssi", "twirssi_replies_store", + ".irssi/scripts/twirssi.json" ); Irssi::settings_add_bool( "twirssi", "twirssi_upgrade_beta", 0 ); Irssi::settings_add_bool( "twirssi", "tweet_to_away", 0 ); Irssi::settings_add_bool( "twirssi", "show_reply_context", 0 ); @@ -1355,12 +1371,12 @@ if ($window) { } if ( my $provider = Irssi::settings_get_str("short_url_provider") ) { + ¬ice("Loading WWW::Shorten::$provider..."); eval "use WWW::Shorten::$provider;"; if ($@) { - ¬ice( -"Failed to load WWW::Shorten::$provider - either clear short_url_provider or install the CPAN module" - ); + ¬ice( "Failed to load WWW::Shorten::$provider - either clear", + "short_url_provider or install the CPAN module"); } } -- 2.39.5 From af895467067b05532b1553b7a1c32f185a506c04 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Fri, 13 Mar 2009 10:38:29 -0700 Subject: [PATCH 03/16] r547 - Tidied --- twirssi.pl | 75 +++++++++++++++++++++++++++--------------------------- 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index a61ed0b..fcf8b90 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -12,7 +12,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 546 $' =~ /(\d+)/; +my ($REV) = '$Rev: 547 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -21,7 +21,7 @@ my ($REV) = '$Rev: 546 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-13 10:37:30 -0700 (Fri, 13 Mar 2009) $', + changed => '$Date: 2009-03-13 10:38:17 -0700 (Fri, 13 Mar 2009) $', ); my $window; @@ -336,14 +336,14 @@ sub cmd_login { { my @user = split /\s*,\s*/, $autouser; my @pass = split /\s*,\s*/, $autopass; - + # if a password ends with a '\', it was meant to escape the comma, and # it should be concatinated with the next one my @unescaped; while (@pass) { my $p = shift @pass; - while ($p =~ /\\$/ and @pass) { - $p .= ",". shift @pass; + while ( $p =~ /\\$/ and @pass ) { + $p .= "," . shift @pass; } push @unescaped, $p; } @@ -731,11 +731,11 @@ sub do_updates { printf $fh "id:%d account:%s nick:%s type:tweet %s\n", $context->{id}, $username, $context->{user}{screen_name}, $ctext; - if ($context->{truncated}) { + if ( $context->{truncated} ) { printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $context->{id}."-url", $username, - $context->{user}{screen_name}, - "http://twitter.com/$context->{user}{screen_name}/status/$context->{id}"; + $context->{id} . "-url", $username, + $context->{user}{screen_name}, +"http://twitter.com/$context->{user}{screen_name}/status/$context->{id}"; } $reply = "reply"; } elsif ($@) { @@ -751,10 +751,10 @@ sub do_updates { and not Irssi::settings_get_bool("show_own_tweets"); printf $fh "id:%d account:%s nick:%s type:%s %s\n", $t->{id}, $username, $t->{user}{screen_name}, $reply, $text; - if ($t->{truncated}) { + if ( $t->{truncated} ) { printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $t->{id}."-url", $username, - $t->{user}{screen_name}, + $t->{id} . "-url", $username, + $t->{user}{screen_name}, "http://twitter.com/$t->{user}{screen_name}/status/$t->{id}"; } } @@ -778,10 +778,10 @@ sub do_updates { $text = &hilight($text); printf $fh "id:%d account:%s nick:%s type:tweet %s\n", $t->{id}, $username, $t->{user}{screen_name}, $text; - if ($t->{truncated}) { + if ( $t->{truncated} ) { printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $t->{id}."-url", $username, - $t->{user}{screen_name}, + $t->{id} . "-url", $username, + $t->{user}{screen_name}, "http://twitter.com/$t->{user}{screen_name}/status/$t->{id}"; } } @@ -925,10 +925,7 @@ sub monitor_child { ]; } elsif ( $meta{type} eq 'ellispis' ) { push @lines, - [ - MSGLEVEL_PUBLIC, - "tweet", $account, $meta{nick}, "", $_ - ]; + [ MSGLEVEL_PUBLIC, "tweet", $account, $meta{nick}, "", $_ ]; } elsif ( $meta{type} eq 'search' ) { push @lines, [ @@ -1145,8 +1142,8 @@ sub sig_complete { ) { # /twitter_reply gets a nick:num $word =~ s/^@//; - @$complist = map { "$_:$id_map{__indexes}{$_}" } - sort {$nicks{$b} <=> $nicks{$a}} + @$complist = map { "$_:$id_map{__indexes}{$_}" } + sort { $nicks{$b} <=> $nicks{$a} } grep /^\Q$word/i, keys %{ $id_map{__indexes} }; } @@ -1203,15 +1200,17 @@ sub shorten { my $data = shift; my $provider = Irssi::settings_get_str("short_url_provider"); - if ( &too_long( $data, 1 ) and $provider ) - { + if ( &too_long( $data, 1 ) and $provider ) { my @args; - if ($provider eq 'Bitly') { - @args[1,2] = split ',', Irssi::settings_get_str("short_url_args"), 2; - unless (@args == 3) { - &ccrap("WWW::Shorten::Bitly requires a username and API key.", - "Set short_url_args to username,API_key or change your", - "short_url_provider."); + if ( $provider eq 'Bitly' ) { + @args[ 1, 2 ] = split ',', + Irssi::settings_get_str("short_url_args"), 2; + unless ( @args == 3 ) { + &ccrap( + "WWW::Shorten::Bitly requires a username and API key.", + "Set short_url_args to username,API_key or change your", + "short_url_provider." + ); return $data; } } @@ -1245,12 +1244,12 @@ Irssi::theme_register( ); Irssi::settings_add_int( "twirssi", "twitter_poll_interval", 300 ); -Irssi::settings_add_str( "twirssi", "twitter_window", "twitter" ); -Irssi::settings_add_str( "twirssi", "bitlbee_server", "bitlbee" ); -Irssi::settings_add_str( "twirssi", "short_url_provider", "TinyURL" ); -Irssi::settings_add_str( "twirssi", "short_url_args", undef ); -Irssi::settings_add_str( "twirssi", "twitter_usernames", undef ); -Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); +Irssi::settings_add_str( "twirssi", "twitter_window", "twitter" ); +Irssi::settings_add_str( "twirssi", "bitlbee_server", "bitlbee" ); +Irssi::settings_add_str( "twirssi", "short_url_provider", "TinyURL" ); +Irssi::settings_add_str( "twirssi", "short_url_args", undef ); +Irssi::settings_add_str( "twirssi", "twitter_usernames", undef ); +Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); Irssi::settings_add_str( "twirssi", "twirssi_nick_color", "%B" ); Irssi::settings_add_str( "twirssi", "twirssi_topic_color", "%r" ); Irssi::settings_add_str( "twirssi", "twirssi_location", @@ -1375,8 +1374,10 @@ if ($window) { eval "use WWW::Shorten::$provider;"; if ($@) { - ¬ice( "Failed to load WWW::Shorten::$provider - either clear", - "short_url_provider or install the CPAN module"); + ¬ice( + "Failed to load WWW::Shorten::$provider - either clear", + "short_url_provider or install the CPAN module" + ); } } -- 2.39.5 From 2c4bb6a4f3a97c91dd7e2e595024358bc496f7a5 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Fri, 13 Mar 2009 10:46:02 -0700 Subject: [PATCH 04/16] r548 - Add new setting twirssi_always_shorten to force all URLs to be shortened --- twirssi.pl | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index fcf8b90..ced5f95 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -12,7 +12,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 547 $' =~ /(\d+)/; +my ($REV) = '$Rev: 548 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -21,7 +21,7 @@ my ($REV) = '$Rev: 547 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-13 10:38:17 -0700 (Fri, 13 Mar 2009) $', + changed => '$Date: 2009-03-13 10:45:47 -0700 (Fri, 13 Mar 2009) $', ); my $window; @@ -1200,7 +1200,14 @@ sub shorten { my $data = shift; my $provider = Irssi::settings_get_str("short_url_provider"); - if ( &too_long( $data, 1 ) and $provider ) { + if ( + ( + Irssi::settings_get_bool("twirssi_always_shorten") + or &too_long( $data, 1 ) + ) + and $provider + ) + { my @args; if ( $provider eq 'Bitly' ) { @args[ 1, 2 ] = split ',', @@ -1267,6 +1274,7 @@ Irssi::settings_add_bool( "twirssi", "twirssi_replies_autonick", 1 ); Irssi::settings_add_bool( "twirssi", "twirssi_use_reply_aliases", 0 ); Irssi::settings_add_bool( "twirssi", "twirssi_notify_timeouts", 1 ); Irssi::settings_add_bool( "twirssi", "twirssi_hilights", 1 ); +Irssi::settings_add_bool( "twirssi", "twirssi_always_shorten", 0 ); Irssi::settings_add_bool( "twirssi", "tweet_window_input", 0 ); $last_poll = time - &get_poll_time; -- 2.39.5 From e12967f01425466111483936dc139aa2389cdc78 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sat, 14 Mar 2009 14:06:19 -0700 Subject: [PATCH 05/16] r549 - Initial support for Net::Identica --- twirssi.pl | 116 +++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 86 insertions(+), 30 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index ced5f95..9d88cad 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -6,13 +6,12 @@ use HTML::Entities; use File::Temp; use LWP::Simple; use Data::Dumper; -use Net::Twitter; $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 548 $' =~ /(\d+)/; +my ($REV) = '$Rev: 549 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -21,13 +20,14 @@ my ($REV) = '$Rev: 548 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-13 10:45:47 -0700 (Fri, 13 Mar 2009) $', + changed => '$Date: 2009-03-14 14:06:07 -0700 (Sat, 14 Mar 2009) $', ); my $window; my $twit; my %twits; my $user; +my $defservice; my $poll; my $last_poll; my %nicks; @@ -79,7 +79,7 @@ sub cmd_direct_as { return; } - return unless &valid_username($username); + return unless $username = &valid_username($username); eval { if ( $twits{$username} @@ -115,7 +115,7 @@ sub cmd_tweet { return; } - &cmd_tweet_as( "$user $data", $server, $win ); + &cmd_tweet_as( "$user\@$defservice $data", $server, $win ); } sub cmd_tweet_as { @@ -132,7 +132,7 @@ sub cmd_tweet_as { return; } - return unless &valid_username($username); + return unless $username = &valid_username($username); $data = &shorten($data); @@ -203,7 +203,7 @@ sub cmd_reply_as { return; } - return unless &valid_username($username); + return unless $username = &valid_username($username); my $nick; $id =~ s/[^\w\d\-:]+//g; @@ -298,10 +298,16 @@ sub cmd_switch { my ( $data, $server, $win ) = @_; $data =~ s/^\s+|\s+$//g; + $data = &normalize_username($data); if ( exists $twits{$data} ) { ¬ice("Switching to $data"); $twit = $twits{$data}; - $user = $data; + if ( $data =~ /(.*)\@(.*)/ ) { + $user = $1; + $defservice = $2; + } else { + ¬ice("Couldn't figure out what service '$data' is on"); + } } else { ¬ice("Unknown user $data"); } @@ -312,7 +318,7 @@ sub cmd_logout { $data =~ s/^\s+|\s+$//g; $data = $user unless $data; - return unless &valid_username($data); + return unless $data = &valid_username($data); ¬ice("Logging out $data..."); $twits{$data}->end_session(); @@ -368,14 +374,29 @@ sub cmd_login { %friends = %nicks = (); - $twit = Net::Twitter->new( + my $service; + if ( $user =~ /^(.*)@(twitter|identica)$/ ) { + ( $user, $service ) = ( $1, $2 ); + } else { + $service = Irssi::settings_get_str("twirssi_default_service"); + } + $defservice = $service = ucfirst lc $service; + + eval "use Net::$service"; + if ($@) { + ¬ice( + "Failed to load Net::$service when trying to log in as $user: $@"); + return; + } + + $twit = "Net::$service"->new( username => $user, password => $pass, source => "twirssi" ); unless ( $twit->verify_credentials() ) { - ¬ice("Login as $user failed"); + ¬ice("Login as $user\@$service failed"); $twit = undef; if ( keys %twits ) { &cmd_switch( ( keys %twits )[0], $server, $win ); @@ -393,10 +414,10 @@ sub cmd_login { return; } - $twits{$user} = $twit; + $twits{"$user\@$service"} = $twit; Irssi::timeout_remove($poll) if $poll; $poll = Irssi::timeout_add( &get_poll_time * 1000, \&get_updates, "" ); - ¬ice("Logged in as $user, loading friends list..."); + ¬ice("Logged in as $user\@$service, loading friends list..."); &load_friends(); ¬ice( "loaded friends: ", scalar keys %friends ); if ( Irssi::settings_get_bool("twirssi_first_run") ) { @@ -646,9 +667,7 @@ sub get_updates { my $new_poll = time; my $error = 0; - $error += &do_updates( $fh, $user, $twit ); foreach ( keys %twits ) { - next if $_ eq $user; $error += &do_updates( $fh, $_, $twits{$_} ); } @@ -731,7 +750,7 @@ sub do_updates { printf $fh "id:%d account:%s nick:%s type:tweet %s\n", $context->{id}, $username, $context->{user}{screen_name}, $ctext; - if ( $context->{truncated} ) { + if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) { printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", $context->{id} . "-url", $username, $context->{user}{screen_name}, @@ -751,7 +770,7 @@ sub do_updates { and not Irssi::settings_get_bool("show_own_tweets"); printf $fh "id:%d account:%s nick:%s type:%s %s\n", $t->{id}, $username, $t->{user}{screen_name}, $reply, $text; - if ( $t->{truncated} ) { + if ( $t->{truncated} and ref($obj) ne 'Net::Identica' ) { printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", $t->{id} . "-url", $username, $t->{user}{screen_name}, @@ -892,8 +911,17 @@ sub monitor_child { } my $account = ""; - if ( $meta{account} ne $user ) { - $account = "$meta{account}: "; + if ( lc $meta{account} ne lc "$user\@$defservice" ) { + $meta{account} =~ s/\@(\w+)$//; + my $service = $1; + if ( + lc $service eq + lc Irssi::settings_get_str("twirssi_default_service") ) + { + $account = "$meta{account}: "; + } else { + $account = "$meta{account}\@$service: "; + } } my $marker = ""; @@ -1114,12 +1142,14 @@ sub too_long { sub valid_username { my $username = shift; + $username = &normalize_username($username); + unless ( exists $twits{$username} ) { ¬ice("Unknown username $username"); - return 0; + return undef; } - return 1; + return $username; } sub logged_in { @@ -1238,6 +1268,30 @@ sub shorten { return $data; } +sub normalize_username { + my $user = shift; + + my ( $username, $service ) = split /\@/, $user, 2; + unless ($service) { + $service = + ucfirst lc Irssi::settings_get_str("twirssi_default_service"); + unless ( exists $twits{"$username\@$service"} ) { + $service = undef; + foreach my $t ( sort keys %twits ) { + next unless $t =~ /^\Q$username\E\@(Twitter|Identica)/; + $service = $1; + last; + } + + unless ($service) { + ¬ice("Can't find a logged in user '$user'"); + } + } + } + + return "$username\@$service"; +} + Irssi::signal_add( "send text", "event_send_text" ); Irssi::theme_register( @@ -1251,14 +1305,15 @@ Irssi::theme_register( ); Irssi::settings_add_int( "twirssi", "twitter_poll_interval", 300 ); -Irssi::settings_add_str( "twirssi", "twitter_window", "twitter" ); -Irssi::settings_add_str( "twirssi", "bitlbee_server", "bitlbee" ); -Irssi::settings_add_str( "twirssi", "short_url_provider", "TinyURL" ); -Irssi::settings_add_str( "twirssi", "short_url_args", undef ); -Irssi::settings_add_str( "twirssi", "twitter_usernames", undef ); -Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); -Irssi::settings_add_str( "twirssi", "twirssi_nick_color", "%B" ); -Irssi::settings_add_str( "twirssi", "twirssi_topic_color", "%r" ); +Irssi::settings_add_str( "twirssi", "twitter_window", "twitter" ); +Irssi::settings_add_str( "twirssi", "bitlbee_server", "bitlbee" ); +Irssi::settings_add_str( "twirssi", "short_url_provider", "TinyURL" ); +Irssi::settings_add_str( "twirssi", "short_url_args", undef ); +Irssi::settings_add_str( "twirssi", "twitter_usernames", undef ); +Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); +Irssi::settings_add_str( "twirssi", "twirssi_default_service", "Twitter" ); +Irssi::settings_add_str( "twirssi", "twirssi_nick_color", "%B" ); +Irssi::settings_add_str( "twirssi", "twirssi_topic_color", "%r" ); Irssi::settings_add_str( "twirssi", "twirssi_location", ".irssi/scripts/twirssi.pl" ); Irssi::settings_add_str( "twirssi", "twirssi_replies_store", @@ -1312,7 +1367,8 @@ if ($window) { "twirssi_dump", sub { print "twits: ", join ", ", - map { "u: $_->{username}" } values %twits; + map { "u: $_->{username}\@" . ref($_) } values %twits; + print "selected: $user\@$defservice"; print "friends: ", join ", ", sort keys %friends; print "nicks: ", join ", ", sort keys %nicks; print "searches: ", Dumper \%{ $id_map{__searches} }; -- 2.39.5 From f8fc7c6e3d309a7c5319be3065a849df8beb3945 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sat, 14 Mar 2009 14:11:21 -0700 Subject: [PATCH 06/16] r550 - Fix it so that the service doesn't have to be properly capitalized when using twitter_switch --- twirssi.pl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 9d88cad..8d5944c 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 549 $' =~ /(\d+)/; +my ($REV) = '$Rev: 550 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 549 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-14 14:06:07 -0700 (Sat, 14 Mar 2009) $', + changed => '$Date: 2009-03-14 14:10:35 -0700 (Sat, 14 Mar 2009) $', ); my $window; @@ -1272,7 +1272,9 @@ sub normalize_username { my $user = shift; my ( $username, $service ) = split /\@/, $user, 2; - unless ($service) { + if ($service) { + $service = ucfirst lc $service; + } else { $service = ucfirst lc Irssi::settings_get_str("twirssi_default_service"); unless ( exists $twits{"$username\@$service"} ) { -- 2.39.5 From 8bc117691a9aedd1c2d1ef4623c8af6cccef77c1 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sun, 15 Mar 2009 18:00:31 -0700 Subject: [PATCH 07/16] r551 - Add twitter_device_updates command, accepts none, im or sms. --- twirssi.pl | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 8d5944c..de43f05 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 550 $' =~ /(\d+)/; +my ($REV) = '$Rev: 551 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 550 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-14 14:10:35 -0700 (Sat, 14 Mar 2009) $', + changed => '$Date: 2009-03-15 18:00:12 -0700 (Sun, 15 Mar 2009) $', ); my $window; @@ -1361,6 +1361,7 @@ if ($window) { Irssi::command_bind( "twitter_unsubscribe", "cmd_del_search" ); Irssi::command_bind( "twitter_list_subscriptions", "cmd_list_search" ); Irssi::command_bind( "twirssi_upgrade", "cmd_upgrade" ); + Irssi::command_bind( "twitter_updates", "get_updates" ); if ( Irssi::settings_get_bool("twirssi_use_reply_aliases") ) { Irssi::command_bind( "reply", "cmd_reply" ); Irssi::command_bind( "reply_as", "cmd_reply_as" ); @@ -1408,7 +1409,14 @@ if ($window) { sub { ¬ice("Stopped following $_[0]"); delete $nicks{ $_[0] }; } ) ); - Irssi::command_bind( "twitter_updates", "get_updates" ); + Irssi::command_bind( + "twitter_device_updates", + &gen_cmd( + "/twitter_device_updates none|im|sms", + "update_delivery_device", + sub { ¬ice("Device updated to $_[0]"); } + ) + ); Irssi::signal_add_last( 'complete word' => \&sig_complete ); ¬ice(" %Y<%C(%B^%C)%N TWIRSSI v%R$VERSION%N (r$REV)"); -- 2.39.5 From 42c35e8ae7a5b2475bc2e5686fb42571d5ffdf52 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sun, 15 Mar 2009 23:10:14 -0700 Subject: [PATCH 08/16] r554 - Fix hilighting given @service --- twirssi.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index de43f05..cc7c055 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 551 $' =~ /(\d+)/; +my ($REV) = '$Rev: 554 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 551 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-15 18:00:12 -0700 (Sun, 15 Mar 2009) $', + changed => '$Date: 2009-03-15 23:09:56 -0700 (Sun, 15 Mar 2009) $', ); my $window; @@ -938,8 +938,8 @@ sub monitor_child { my $hilight_color = $irssi_to_mirc_colors{ Irssi::settings_get_str("hilight_color") }; - if ( ( $_ =~ /\@$meta{account}\W/i ) - && Irssi::settings_get_bool("twirssi_hilights") ) + if ( $_ eq '@'.substr($meta{account}, 0, index($meta{account}, "@")) + and Irssi::settings_get_bool("twirssi_hilights") ) { $meta{nick} = "\cC$hilight_color$meta{nick}\cO"; $hilight = MSGLEVEL_HILIGHT; -- 2.39.5 From e37690d9d648b1455f48129a5860b763da42d177 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sun, 15 Mar 2009 23:15:50 -0700 Subject: [PATCH 09/16] r555 - Fix hilighting given @service, again --- twirssi.pl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index cc7c055..4bb7078 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 554 $' =~ /(\d+)/; +my ($REV) = '$Rev: 555 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 554 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-15 23:09:56 -0700 (Sun, 15 Mar 2009) $', + changed => '$Date: 2009-03-15 23:15:33 -0700 (Sun, 15 Mar 2009) $', ); my $window; @@ -938,7 +938,9 @@ sub monitor_child { my $hilight_color = $irssi_to_mirc_colors{ Irssi::settings_get_str("hilight_color") }; - if ( $_ eq '@'.substr($meta{account}, 0, index($meta{account}, "@")) + my $nick = + '@' . substr( $meta{account}, 0, index( $meta{account}, "@" ) ); + if ( $_ =~ /\Q$nick\E(?:\W|$)/i and Irssi::settings_get_bool("twirssi_hilights") ) { $meta{nick} = "\cC$hilight_color$meta{nick}\cO"; -- 2.39.5 From 6edd2e649ba18daadccc1727d775baa627a525c0 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Mon, 16 Mar 2009 15:34:24 -0700 Subject: [PATCH 10/16] r559 - Release 2.2.0 --- twirssi.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 4bb7078..9a69813 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -10,8 +10,8 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); -$VERSION = "2.1.3beta"; -my ($REV) = '$Rev: 555 $' =~ /(\d+)/; +$VERSION = "2.2.0"; +my ($REV) = '$Rev: 559 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 555 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-15 23:15:33 -0700 (Sun, 15 Mar 2009) $', + changed => '$Date: 2009-03-16 15:34:12 -0700 (Mon, 16 Mar 2009) $', ); my $window; -- 2.39.5 From 108f9ee00b45b3e0d85c06684d158675828c6364 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Thu, 19 Mar 2009 11:44:16 -0700 Subject: [PATCH 11/16] r569 - When a tweet is too long, show the URL on the same line --- twirssi.pl | 40 ++++++++++++++++------------------------ 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 9a69813..c4b4e4b 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -10,8 +10,8 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); -$VERSION = "2.2.0"; -my ($REV) = '$Rev: 559 $' =~ /(\d+)/; +$VERSION = "2.2.1beta"; +my ($REV) = '$Rev: 569 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 559 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-16 15:34:12 -0700 (Mon, 16 Mar 2009) $', + changed => '$Date: 2009-03-19 11:44:03 -0700 (Thu, 19 Mar 2009) $', ); my $window; @@ -747,15 +747,14 @@ sub do_updates { if ($context) { my $ctext = decode_entities( $context->{text} ); $ctext = &hilight($ctext); + if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) { + $ctext .= + " -- http://twitter.com/$context->{user}{screen_name}" + . "/status/$context->{id}"; + } printf $fh "id:%d account:%s nick:%s type:tweet %s\n", $context->{id}, $username, $context->{user}{screen_name}, $ctext; - if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) { - printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $context->{id} . "-url", $username, - $context->{user}{screen_name}, -"http://twitter.com/$context->{user}{screen_name}/status/$context->{id}"; - } $reply = "reply"; } elsif ($@) { print $fh "type:debug request to get context failed: $@"; @@ -768,14 +767,12 @@ sub do_updates { next if $t->{user}{screen_name} eq $username and not Irssi::settings_get_bool("show_own_tweets"); - printf $fh "id:%d account:%s nick:%s type:%s %s\n", - $t->{id}, $username, $t->{user}{screen_name}, $reply, $text; if ( $t->{truncated} and ref($obj) ne 'Net::Identica' ) { - printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $t->{id} . "-url", $username, - $t->{user}{screen_name}, - "http://twitter.com/$t->{user}{screen_name}/status/$t->{id}"; + $text .= " -- http://twitter.com/$t->{user}{screen_name}" + . "/status/$t->{id}"; } + printf $fh "id:%d account:%s nick:%s type:%s %s\n", + $t->{id}, $username, $t->{user}{screen_name}, $reply, $text; } print scalar localtime, " - Polling for replies" if &debug; @@ -795,14 +792,12 @@ sub do_updates { my $text = decode_entities( $t->{text} ); $text = &hilight($text); - printf $fh "id:%d account:%s nick:%s type:tweet %s\n", - $t->{id}, $username, $t->{user}{screen_name}, $text; if ( $t->{truncated} ) { - printf $fh "id:%s account:%s nick:%s type:ellispis %s\n", - $t->{id} . "-url", $username, - $t->{user}{screen_name}, - "http://twitter.com/$t->{user}{screen_name}/status/$t->{id}"; + $text .= " -- http://twitter.com/$t->{user}{screen_name}" + . "/status/$t->{id}"; } + printf $fh "id:%d account:%s nick:%s type:tweet %s\n", + $t->{id}, $username, $t->{user}{screen_name}, $text; } print scalar localtime, " - Polling for DMs" if &debug; @@ -953,9 +948,6 @@ sub monitor_child { ( MSGLEVEL_PUBLIC | $hilight ), $meta{type}, $account, $meta{nick}, $marker, $_ ]; - } elsif ( $meta{type} eq 'ellispis' ) { - push @lines, - [ MSGLEVEL_PUBLIC, "tweet", $account, $meta{nick}, "", $_ ]; } elsif ( $meta{type} eq 'search' ) { push @lines, [ -- 2.39.5 From 2fa1c083e78f8424ace8f5841629fb42a039cefc Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Sun, 5 Apr 2009 19:22:53 -0700 Subject: [PATCH 12/16] r597 - Add a /retweet and /retweet_as commands. --- twirssi.pl | 119 +++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 111 insertions(+), 8 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index c4b4e4b..b9a31f0 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.2.1beta"; -my ($REV) = '$Rev: 569 $' =~ /(\d+)/; +my ($REV) = '$Rev: 597 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 569 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-03-19 11:44:03 -0700 (Thu, 19 Mar 2009) $', + changed => '$Date: 2009-04-05 19:22:22 -0700 (Sun, 05 Apr 2009) $', ); my $window; @@ -104,6 +104,105 @@ sub cmd_direct_as { } } +sub cmd_retweet { + my ( $data, $server, $win ) = @_; + + return unless &logged_in($twit); + + $data =~ s/^\s+|\s+$//; + unless ($data) { + ¬ice("Usage: /retweet [comment]"); + return; + } + + my ( $id, $data ) = split ' ', $data, 2; + + &cmd_retweet_as( "$user $id $data", $server, $win ); +} + +sub cmd_retweet_as { + my ( $data, $server, $win ) = @_; + + unless ( Irssi::settings_get_bool("twirssi_track_replies") ) { + ¬ice("twirssi_track_replies is required in order to reteet."); + return; + } + + return unless &logged_in($twit); + + $data =~ s/^\s+|\s+$//; + my ( $username, $id, $data ) = split ' ', $data, 3; + + unless ( $username ) { + ¬ice("Usage: /retweet_as [comment]"); + return; + } + + return unless $username = &valid_username($username); + + my $nick; + $id =~ s/[^\w\d\-:]+//g; + ( $nick, $id ) = split /:/, $id; + unless ( exists $id_map{ lc $nick } ) { + ¬ice("Can't find a tweet from $nick to retweet!"); + return; + } + + $id = $id_map{__indexes}{$nick} unless $id; + unless ( $id_map{ lc $nick }[$id] ) { + ¬ice("Can't find a tweet numbered $id from $nick to retweet!"); + return; + } + + unless ( $id_map{__tweets}{ lc $nick }[$id] ) { + ¬ice("The text of this tweet isn't saved, sorry!"); + return; + } + +# Irssi::settings_add_str( "twirssi", "twirssi_retweet_format", 'RT $n: $t ${-- $c$}' ); + my $text = Irssi::settings_get_str("twirssi_retweet_format"); + $text =~ s/\$n/$nick/g; + if ($data) { + $text =~ s/\${|\$}//g; + $text =~ s/\$c/$data/; + } else { + $text =~ s/\${.*?\$}//; + } + $text =~ s/\$t/$id_map{__tweets}{ lc $nick }[$id]/; + + $data = &shorten($text); + + return if &too_long($data); + + my $success = 1; + eval { + unless ( + $twits{$username}->update( + { + status => $data, + in_reply_to_status_id => $id_map{ lc $nick }[$id] + } + ) + ) + { + ¬ice("Update failed"); + $success = 0; + } + }; + return unless $success; + + if ($@) { + ¬ice("Update caused an error: $@. Aborted"); + return; + } + + foreach ( $data =~ /@([-\w]+)/ ) { + $nicks{$1} = time; + } + + ¬ice("Retweet sent"); +} + sub cmd_tweet { my ( $data, $server, $win ) = @_; @@ -173,10 +272,9 @@ sub cmd_reply { return; } - $data =~ s/^\s+|\s+$//; my ( $id, $data ) = split ' ', $data, 2; unless ( $id and $data ) { - ¬ice("Usage: /reply_as "); + ¬ice("Usage: /reply "); return; } @@ -926,9 +1024,10 @@ sub monitor_child { and $meta{id} ) { $marker = ( $id_map{__indexes}{ $meta{nick} } + 1 ) % 100; - $id_map{ lc $meta{nick} }[$marker] = $meta{id}; - $id_map{__indexes}{ $meta{nick} } = $marker; - $marker = ":$marker"; + $id_map{ lc $meta{nick} }[$marker] = $meta{id}; + $id_map{__indexes}{ $meta{nick} } = $marker; + $id_map{__tweets}{ lc $meta{nick} }[$marker] = $_; + $marker = ":$marker"; } my $hilight_color = @@ -1160,7 +1259,7 @@ sub sig_complete { my ( $complist, $window, $word, $linestart, $want_space ) = @_; if ( - $linestart =~ /^\/twitter_reply(?:_as)?\s*$/ + $linestart =~ /^\/(?:retweet|twitter_reply)(?:_as)?\s*$/ or ( Irssi::settings_get_bool("twirssi_use_reply_aliases") and $linestart =~ /^\/reply(?:_as)?\s*$/ ) ) @@ -1310,6 +1409,8 @@ Irssi::settings_add_str( "twirssi", "twitter_passwords", undef ); Irssi::settings_add_str( "twirssi", "twirssi_default_service", "Twitter" ); Irssi::settings_add_str( "twirssi", "twirssi_nick_color", "%B" ); Irssi::settings_add_str( "twirssi", "twirssi_topic_color", "%r" ); +Irssi::settings_add_str( "twirssi", "twirssi_retweet_format", + 'RT $n: "$t" ${-- $c$}' ); Irssi::settings_add_str( "twirssi", "twirssi_location", ".irssi/scripts/twirssi.pl" ); Irssi::settings_add_str( "twirssi", "twirssi_replies_store", @@ -1346,6 +1447,8 @@ if ($window) { Irssi::command_bind( "dm_as", "cmd_direct_as" ); Irssi::command_bind( "tweet", "cmd_tweet" ); Irssi::command_bind( "tweet_as", "cmd_tweet_as" ); + Irssi::command_bind( "retweet", "cmd_retweet" ); + Irssi::command_bind( "retweet_as", "cmd_retweet_as" ); Irssi::command_bind( "twitter_reply", "cmd_reply" ); Irssi::command_bind( "twitter_reply_as", "cmd_reply_as" ); Irssi::command_bind( "twitter_login", "cmd_login" ); -- 2.39.5 From 2492f53ab359ac856c8df4ff64305c4214cde461 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Tue, 7 Apr 2009 07:49:51 -0700 Subject: [PATCH 13/16] r599 - fix nick in retweet --- twirssi.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index b9a31f0..e6142cd 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.2.1beta"; -my ($REV) = '$Rev: 597 $' =~ /(\d+)/; +my ($REV) = '$Rev: 599 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 597 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-04-05 19:22:22 -0700 (Sun, 05 Apr 2009) $', + changed => '$Date: 2009-04-07 07:49:19 -0700 (Tue, 07 Apr 2009) $', ); my $window; @@ -161,7 +161,7 @@ sub cmd_retweet_as { # Irssi::settings_add_str( "twirssi", "twirssi_retweet_format", 'RT $n: $t ${-- $c$}' ); my $text = Irssi::settings_get_str("twirssi_retweet_format"); - $text =~ s/\$n/$nick/g; + $text =~ s/\$n/\@$nick/g; if ($data) { $text =~ s/\${|\$}//g; $text =~ s/\$c/$data/; -- 2.39.5 From 58fa79277e8853a34e2982b994d7fb9b93a265c3 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Thu, 9 Apr 2009 21:23:25 -0700 Subject: [PATCH 14/16] r607 - Change calls to twitter to use the since_id param. Fix things so that we don't try to get the same context over and over while waiting for do_updates to complete. --- twirssi.pl | 150 +++++++++++++++++++++++++++++++++-------------------- 1 file changed, 95 insertions(+), 55 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index e6142cd..2375ba9 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.2.1beta"; -my ($REV) = '$Rev: 599 $' =~ /(\d+)/; +my ($REV) = '$Rev: 607 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 599 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-04-07 07:49:19 -0700 (Tue, 07 Apr 2009) $', + changed => '$Date: 2009-04-09 21:22:55 -0700 (Thu, 09 Apr 2009) $', ); my $window; @@ -133,7 +133,7 @@ sub cmd_retweet_as { $data =~ s/^\s+|\s+$//; my ( $username, $id, $data ) = split ' ', $data, 3; - unless ( $username ) { + unless ($username) { ¬ice("Usage: /retweet_as [comment]"); return; } @@ -765,8 +765,9 @@ sub get_updates { my $new_poll = time; my $error = 0; + my %context_cache; foreach ( keys %twits ) { - $error += &do_updates( $fh, $_, $twits{$_} ); + $error++ unless &do_updates( $fh, $_, $twits{$_}, \%context_cache ); } my ( $added, $removed ) = &load_friends($fh); @@ -784,9 +785,9 @@ sub get_updates { if ($error) { print $fh "type:debug Update encountered errors. Aborted\n"; - print $fh $last_poll; + print $fh "-- $last_poll"; } else { - print $fh $new_poll; + print $fh "-- $new_poll"; } close $fh; exit; @@ -795,36 +796,47 @@ sub get_updates { } sub do_updates { - my ( $fh, $username, $obj ) = @_; + my ( $fh, $username, $obj, $cache ) = @_; my $rate_limit = $obj->rate_limit_status(); if ( $rate_limit and $rate_limit->{remaining_hits} < 1 ) { ¬ice("Rate limit exceeded for $username"); - return 1; + return undef; } print scalar localtime, " - Polling for updates for $username" if &debug; my $tweets; - eval { $tweets = $obj->friends_timeline(); }; + my $new_poll_id = 0; + eval { + if ( $id_map{__last_id}{$username}{timeline} ) + { + $tweets = $obj->friends_timeline( + { since_id => $id_map{__last_id}{$username}{timeline} } ); + } else { + $tweets = $obj->friends_timeline(); + } + }; if ($@) { - print $fh - "type:debug Error during friends_timeline call: $@. Aborted.\n"; - return 1; + print $fh "type:debug Error during friends_timeline call: Aborted.\n"; + print $fh "type:debug : $_\n" foreach split /\n/, Dumper($@); + return undef; } unless ( ref $tweets ) { if ( $obj->can("get_error") ) { - my $error; + my $error = "Unknown error"; eval { $error = JSON::Any->jsonToObj( $obj->get_error() ) }; - if ($@) { $error = $obj->get_error() } - print $fh "type:debug API Error during friends_timeline call: ", - "$error Aborted.\n"; + unless ($@) { $error = $obj->get_error() } + print $fh + "type:debug API Error during friends_timeline call: Aborted\n"; + print $fh "type:debug : $_\n" foreach split /\n/, Dumper($error); + } else { print $fh "type:debug API Error during friends_timeline call. Aborted.\n"; } - return 1; + return undef; } foreach my $t ( reverse @$tweets ) { @@ -838,9 +850,14 @@ sub do_updates { { $nicks{ $t->{in_reply_to_screen_name} } = time; my $context; - eval { - $context = $obj->show_status( $t->{in_reply_to_status_id} ); - }; + unless ( $cache->{ $t->{in_reply_to_status_id} } ) { + eval { + $cache->{ $t->{in_reply_to_status_id} } = + $obj->show_status( $t->{in_reply_to_status_id} ); + }; + + } + $context = $cache->{ $t->{in_reply_to_status_id} }; if ($context) { my $ctext = decode_entities( $context->{text} ); @@ -854,12 +871,6 @@ sub do_updates { $context->{id}, $username, $context->{user}{screen_name}, $ctext; $reply = "reply"; - } elsif ($@) { - print $fh "type:debug request to get context failed: $@"; - } else { - print $fh -"type:debug Failed to get context from $t->{in_reply_to_screen_name}\n" - if &debug; } } next @@ -871,17 +882,27 @@ sub do_updates { } printf $fh "id:%d account:%s nick:%s type:%s %s\n", $t->{id}, $username, $t->{user}{screen_name}, $reply, $text; + $new_poll_id = $t->{id} if $new_poll_id < $t->{id}; } + printf $fh "id:%d account:%s type:last_id timeline\n", + $new_poll_id, $username; print scalar localtime, " - Polling for replies" if &debug; + $new_poll_id = 0; eval { - $tweets = $obj->replies( { since => HTTP::Date::time2str($last_poll) } ) - || []; + if ( $id_map{__last_id}{$username}{reply} ) + { + $tweets = $obj->replies( + { since_id => $id_map{__last_id}{$username}{reply} } ) + || []; + } else { + $tweets = $obj->replies() || []; + } }; if ($@) { print $fh "type:debug Error during replies call. Aborted.\n"; - return 1; + return undef; } foreach my $t ( reverse @$tweets ) { @@ -896,18 +917,26 @@ sub do_updates { } printf $fh "id:%d account:%s nick:%s type:tweet %s\n", $t->{id}, $username, $t->{user}{screen_name}, $text; + $new_poll_id = $t->{id} if $new_poll_id < $t->{id}; } + printf $fh "id:%d account:%s type:last_id reply\n", $new_poll_id, $username; print scalar localtime, " - Polling for DMs" if &debug; + $new_poll_id = 0; eval { - $tweets = - $obj->direct_messages( { since => HTTP::Date::time2str($last_poll) } ) - || []; + if ( $id_map{__last_id}{$username}{dm} ) + { + $tweets = $obj->direct_messages( + { since_id => $id_map{__last_id}{$username}{dm} } ) + || []; + } else { + $tweets = $obj->direct_messages() || []; + } }; if ($@) { print $fh "type:debug Error during direct_messages call. Aborted.\n"; - return 1; + return undef; } foreach my $t ( reverse @$tweets ) { @@ -915,7 +944,9 @@ sub do_updates { $text = &hilight($text); printf $fh "id:%d account:%s nick:%s type:dm %s\n", $t->{id}, $username, $t->{sender_screen_name}, $text; + $new_poll_id = $t->{id} if $new_poll_id < $t->{id}; } + printf $fh "id:%d account:%s type:last_id dm\n", $new_poll_id, $username; print scalar localtime, " - Polling for subscriptions" if &debug; if ( $obj->can('search') and $id_map{__searches}{$username} ) { @@ -935,14 +966,13 @@ sub do_updates { if ($@) { print $fh "type:debug Error during search($topic) call. Aborted.\n"; - return 1; + return undef; } unless ( $search->{max_id} ) { - print $fh -"type:debug Invalid search results when searching for $topic.", - " Aborted.\n"; - return 1; + print $fh "type:debug Invalid search results when searching", + " for $topic. Aborted.\n"; + return undef; } $id_map{__searches}{$username}{$topic} = $search->{max_id}; @@ -954,13 +984,16 @@ sub do_updates { $text = &hilight($text); printf $fh "id:%d account:%s nick:%s type:search topic:%s %s\n", $t->{id}, $username, $t->{from_user}, $topic, $text; + $new_poll_id = $t->{id} + if not $new_poll_id + or $t->{id} < $new_poll_id; } } } print scalar localtime, " - Done" if &debug; - return 0; + return 1; } sub monitor_child { @@ -970,7 +1003,7 @@ sub monitor_child { print scalar localtime, " - checking child log at $filename ($attempt)" if &debug; - my $new_last_poll; + my ($new_last_poll); # first time we run we don't want to print out *everything*, so we just # pretend @@ -985,13 +1018,14 @@ sub monitor_child { last if /^__friends__/; my $hilight = 0; my %meta; + foreach my $key (qw/id account nick type topic/) { if (s/^$key:(\S+)\s*//) { $meta{$key} = $1; } } - if ( not $meta{type} or $meta{type} ne 'searchid' ) { + if ( not $meta{type} or $meta{type} !~ /searchid|last_id/ ) { if ( exists $meta{id} and exists $new_cache{ $meta{id} } ) { next; } @@ -1004,17 +1038,17 @@ sub monitor_child { } my $account = ""; - if ( lc $meta{account} ne lc "$user\@$defservice" ) { - $meta{account} =~ s/\@(\w+)$//; - my $service = $1; - if ( - lc $service eq - lc Irssi::settings_get_str("twirssi_default_service") ) - { - $account = "$meta{account}: "; - } else { - $account = "$meta{account}\@$service: "; - } + $meta{account} =~ s/\@(\w+)$//; + $meta{service} = $1; + if ( + lc $meta{service} eq + lc Irssi::settings_get_str("twirssi_default_service") ) + { + $account = "$meta{account}: " + if lc "$meta{account}\@$meta{service}" ne lc + "$user\@$defservice"; + } else { + $account = "$meta{account}\@$meta{service}: "; } my $marker = ""; @@ -1080,6 +1114,11 @@ sub monitor_child { } elsif (&debug) { print "Search '$meta{topic}' returned invalid id $meta{id}"; } + } elsif ( $meta{type} eq 'last_id' ) { + $id_map{__last_id}{"$meta{account}\@$meta{service}"}{$_} = + $meta{id} + if $id_map{__last_id}{"$meta{account}\@$meta{service}"}{$_} < + $meta{id}; } elsif ( $meta{type} eq 'error' ) { push @lines, [ MSGLEVEL_MSGS, $_ ]; } elsif ( $meta{type} eq 'debug' ) { @@ -1091,8 +1130,8 @@ sub monitor_child { %friends = (); while () { - if (/^\d+$/) { - $new_last_poll = $_; + if (/^-- (\d+)$/) { + ($new_last_poll) = ($1); last; } my ( $f, $t ) = split ' ', $_; @@ -1100,7 +1139,8 @@ sub monitor_child { } if ($new_last_poll) { - print "new last_poll = $new_last_poll" if &debug; + print "new last_poll = $new_last_poll" if &debug; + print "new last_poll_id = ", Dumper( $id_map{__last_id} ) if &debug; if ($suppress) { print "First call, not printing updates" if &debug; } else { -- 2.39.5 From 9c8f755253f25cf58236420a7d2c16a34093bcca Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Fri, 10 Apr 2009 23:31:14 -0700 Subject: [PATCH 15/16] r610 - Drop since_id for friends_timeline, just request the last 100 entries --- twirssi.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 2375ba9..3e92f80 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -11,7 +11,7 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); $VERSION = "2.2.1beta"; -my ($REV) = '$Rev: 607 $' =~ /(\d+)/; +my ($REV) = '$Rev: 610 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 607 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-04-09 21:22:55 -0700 (Thu, 09 Apr 2009) $', + changed => '$Date: 2009-04-10 23:30:55 -0700 (Fri, 10 Apr 2009) $', ); my $window; @@ -810,8 +810,7 @@ sub do_updates { eval { if ( $id_map{__last_id}{$username}{timeline} ) { - $tweets = $obj->friends_timeline( - { since_id => $id_map{__last_id}{$username}{timeline} } ); + $tweets = $obj->friends_timeline( { count => 100 } ); } else { $tweets = $obj->friends_timeline(); } -- 2.39.5 From 24bd606ef5f30a60a069ca067e08af6b615deb38 Mon Sep 17 00:00:00 2001 From: Dan Boger Date: Fri, 10 Apr 2009 23:47:33 -0700 Subject: [PATCH 16/16] r611 - Tag 2.2.1 release --- twirssi.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/twirssi.pl b/twirssi.pl index 3e92f80..6e01018 100644 --- a/twirssi.pl +++ b/twirssi.pl @@ -10,8 +10,8 @@ $Data::Dumper::Indent = 1; use vars qw($VERSION %IRSSI); -$VERSION = "2.2.1beta"; -my ($REV) = '$Rev: 610 $' =~ /(\d+)/; +$VERSION = "2.2.1"; +my ($REV) = '$Rev: 611 $' =~ /(\d+)/; %IRSSI = ( authors => 'Dan Boger', contact => 'zigdon@gmail.com', @@ -20,7 +20,7 @@ my ($REV) = '$Rev: 610 $' =~ /(\d+)/; . 'Can optionally set your bitlbee /away message to same', license => 'GNU GPL v2', url => 'http://twirssi.com', - changed => '$Date: 2009-04-10 23:30:55 -0700 (Fri, 10 Apr 2009) $', + changed => '$Date: 2009-04-10 23:47:19 -0700 (Fri, 10 Apr 2009) $', ); my $window; -- 2.39.5