1.7.3 - r354 - Strip out newlines from incoming tweets

[twirssi-net-twitter-lite.git] / twirssi.pl

diff --git a/twirssi.pl b/twirssi.pl
index 0a170cb67725831648236ff5e9c22d1d5a364e85..c3ce58ff86b77922834e74b5add39168246a79e5 100644 (file)
--- a/twirssi.pl
+++ b/twirssi.pl
@@ -1,7 +1,6 @@
 use strict;
 use Irssi;
 use Irssi::Irc;
 use strict;
 use Irssi;
 use Irssi::Irc;

-use Net::Twitter;

 use HTTP::Date;
 use HTML::Entities;
 use File::Temp;
 use HTTP::Date;
 use HTML::Entities;
 use File::Temp;


@@ -9,10 +8,18 @@ use LWP::Simple;
 use Data::Dumper;
 $Data::Dumper::Indent = 1;
 
 use Data::Dumper;
 $Data::Dumper::Indent = 1;
 

+BEGIN {
+    $ENV{JSON_ANY_ORDER} = "JSON Syck DWIW";
+    require JSON::Any;
+    import JSON::Any;
+    require Net::Twitter;
+    import Net::Twitter;
+}
+

 use vars qw($VERSION %IRSSI);
 
 use vars qw($VERSION %IRSSI);
 

-$VERSION = "1.7.2";
-my ($REV) = '$Rev: 349 $' =~ /(\d+)/;
+$VERSION = "1.7.3";
+my ($REV) = '$Rev: 354 $' =~ /(\d+)/;

 %IRSSI = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
 %IRSSI = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',


@@ -21,7 +28,7 @@ my ($REV) = '$Rev: 349 $' =~ /(\d+)/;
       . 'Can optionally set your bitlbee /away message to same',
     license => 'GNU GPL v2',
     url     => 'http://tinyurl.com/twirssi',
       . 'Can optionally set your bitlbee /away message to same',
     license => 'GNU GPL v2',
     url     => 'http://tinyurl.com/twirssi',

-    changed => '$Date: 2009-01-06 11:16:45 -0800 (Tue, 06 Jan 2009) $',
+    changed => '$Date: 2009-01-08 14:46:04 -0800 (Thu, 08 Jan 2009) $',

 );
 
 my $window;
 );
 
 my $window;


@@ -38,10 +45,7 @@ my %id_map;
 sub cmd_direct {
     my ( $data, $server, $win ) = @_;
 
 sub cmd_direct {
     my ( $data, $server, $win ) = @_;
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     my ( $target, $text ) = split ' ', $data, 2;
     unless ( $target and $text ) {
 
     my ( $target, $text ) = split ' ', $data, 2;
     unless ( $target and $text ) {


@@ -55,10 +59,7 @@ sub cmd_direct {
 sub cmd_direct_as {
     my ( $data, $server, $win ) = @_;
 
 sub cmd_direct_as {
     my ( $data, $server, $win ) = @_;
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     my ( $username, $target, $text ) = split ' ', $data, 3;
     unless ( $username and $target and $text ) {
 
     my ( $username, $target, $text ) = split ' ', $data, 3;
     unless ( $username and $target and $text ) {


@@ -66,10 +67,7 @@ sub cmd_direct_as {
         return;
     }
 
         return;
     }
 

-    unless ( exists $twits{$username} ) {
-        &notice("Unknown username $username");
-        return;
-    }
+    return unless &valid_username($username);

 
     eval {
         unless ( $twits{$username}
 
     eval {
         unless ( $twits{$username}


@@ -92,10 +90,7 @@ sub cmd_direct_as {
 sub cmd_tweet {
     my ( $data, $server, $win ) = @_;
 
 sub cmd_tweet {
     my ( $data, $server, $win ) = @_;
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     $data =~ s/^\s+|\s+$//;
     unless ($data) {
 
     $data =~ s/^\s+|\s+$//;
     unless ($data) {


@@ -109,10 +104,7 @@ sub cmd_tweet {
 sub cmd_tweet_as {
     my ( $data, $server, $win ) = @_;
 
 sub cmd_tweet_as {
     my ( $data, $server, $win ) = @_;
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     $data =~ s/^\s+|\s+$//;
     my ( $username, $data ) = split ' ', $data, 2;
 
     $data =~ s/^\s+|\s+$//;
     my ( $username, $data ) = split ' ', $data, 2;


@@ -122,10 +114,7 @@ sub cmd_tweet_as {
         return;
     }
 
         return;
     }
 

-    unless ( exists $twits{$username} ) {
-        &notice("Unknown username $username");
-        return;
-    }
+    return unless &valid_username($username);

 
     if ( Irssi::settings_get_str("short_url_provider") ) {
         foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) {
 
     if ( Irssi::settings_get_str("short_url_provider") ) {
         foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) {


@@ -136,11 +125,7 @@ sub cmd_tweet_as {
         }
     }
 
         }
     }
 

-    if ( length $data > 140 ) {
-        &notice(
-            "Tweet too long (" . length($data) . " characters) - aborted" );
-        return;
-    }
+    return if &too_long($data);

 
     eval {
         unless ( $twits{$username}->update($data) )
 
     eval {
         unless ( $twits{$username}->update($data) )


@@ -159,21 +144,7 @@ sub cmd_tweet_as {
         $nicks{$1} = time;
     }
 
         $nicks{$1} = time;
     }
 

-    my $away = 0;
-    if (    Irssi::settings_get_bool("tweet_to_away")
-        and $data !~ /\@\w/
-        and $data !~ /^[dD] / )
-    {
-        my $server =
-          Irssi::server_find_tag( Irssi::settings_get_str("bitlbee_server") );
-        if ($server) {
-            $server->send_raw("away :$data");
-            $away = 1;
-        } else {
-            &notice( "Can't find bitlbee server.",
-                "Update bitlbee_server or disable tweet_to_away" );
-        }
-    }
+    my $away = &update_away($data);

 
     &notice( "Update sent" . ( $away ? " (and away msg set)" : "" ) );
 }
 
     &notice( "Update sent" . ( $away ? " (and away msg set)" : "" ) );
 }


@@ -181,10 +152,7 @@ sub cmd_tweet_as {
 sub cmd_reply {
     my ( $data, $server, $win ) = @_;
 
 sub cmd_reply {
     my ( $data, $server, $win ) = @_;
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     $data =~ s/^\s+|\s+$//;
     unless ($data) {
 
     $data =~ s/^\s+|\s+$//;
     unless ($data) {


@@ -212,10 +180,7 @@ sub cmd_reply_as {
         return;
     }
 
         return;
     }
 

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+    return unless &logged_in($twit);

 
     $data =~ s/^\s+|\s+$//;
     my ( $username, $id, $data ) = split ' ', $data, 3;
 
     $data =~ s/^\s+|\s+$//;
     my ( $username, $id, $data ) = split ' ', $data, 3;


@@ -225,10 +190,7 @@ sub cmd_reply_as {
         return;
     }
 
         return;
     }
 

-    unless ( exists $twits{$username} ) {
-        &notice("Unknown username $username");
-        return;
-    }
+    return unless &valid_username($username);

 
     my $nick;
     $id =~ s/[^\w\d\-:]+//g;
 
     my $nick;
     $id =~ s/[^\w\d\-:]+//g;


@@ -257,11 +219,7 @@ sub cmd_reply_as {
         }
     }
 
         }
     }
 

-    if ( length $data > 140 ) {
-        &notice(
-            "Tweet too long (" . length($data) . " characters) - aborted" );
-        return;
-    }
+    return if &too_long($data);

 
     eval {
         unless (
 
     eval {
         unless (


@@ -287,21 +245,7 @@ sub cmd_reply_as {
         $nicks{$1} = time;
     }
 
         $nicks{$1} = time;
     }
 

-    my $away = 0;
-    if (    Irssi::settings_get_bool("tweet_to_away")
-        and $data !~ /\@\w/
-        and $data !~ /^[dD] / )
-    {
-        my $server =
-          Irssi::server_find_tag( Irssi::settings_get_str("bitlbee_server") );
-        if ($server) {
-            $server->send_raw("away :$data");
-            $away = 1;
-        } else {
-            &notice( "Can't find bitlbee server.",
-                "Update bitlbee_server or disalbe tweet_to_away" );
-        }
-    }
+    my $away = &update_away($data);

 
     &notice( "Update sent" . ( $away ? " (and away msg set)" : "" ) );
 }
 
     &notice( "Update sent" . ( $away ? " (and away msg set)" : "" ) );
 }


@@ -312,10 +256,7 @@ sub gen_cmd {
     return sub {
         my ( $data, $server, $win ) = @_;
 
     return sub {
         my ( $data, $server, $win ) = @_;
 

-        unless ($twit) {
-            &notice("Not logged in!  Use /twitter_login username pass!");
-            return;
-        }
+        return unless &logged_in($twit);

 
         $data =~ s/^\s+|\s+$//;
         unless ($data) {
 
         $data =~ s/^\s+|\s+$//;
         unless ($data) {


@@ -357,12 +298,12 @@ sub cmd_logout {
     my ( $data, $server, $win ) = @_;
 
     $data =~ s/^\s+|\s+$//g;
     my ( $data, $server, $win ) = @_;
 
     $data =~ s/^\s+|\s+$//g;

-    if ( $data and exists $twits{$data} ) {
+    return unless &valid_username($data);
+
+    if ($data) {

         &notice("Logging out $data...");
         $twits{$data}->end_session();
         delete $twits{$data};
         &notice("Logging out $data...");
         $twits{$data}->end_session();
         delete $twits{$data};

-    } elsif ($data) {
-        &notice("Unknown username '$data'");

     } else {
         &notice("Logging out $user...");
         $twit->end_session();
     } else {
         &notice("Logging out $user...");
         $twit->end_session();


@@ -564,7 +505,7 @@ sub load_friends {
     };
 
     if ($@) {
     };
 
     if ($@) {

-        print $fh "type:error Error during friends list update.  Aborted.\n";
+        print $fh "type:debug Error during friends list update.  Aborted.\n";

         return;
     }
 
         return;
     }
 


@@ -598,10 +539,8 @@ sub get_updates {
               . Irssi::settings_get_str('twitter_window')
               . "'.  Create it or change the value of twitter_window" );
     }
               . Irssi::settings_get_str('twitter_window')
               . "'.  Create it or change the value of twitter_window" );
     }

-    unless ($twit) {
-        &notice("Not logged in!  Use /twitter_login username pass!");
-        return;
-    }
+
+    return unless &logged_in($twit);

 
     my ( $fh, $filename ) = File::Temp::tempfile();
     my $pid = fork();
 
     my ( $fh, $filename ) = File::Temp::tempfile();
     my $pid = fork();


@@ -637,7 +576,7 @@ sub get_updates {
         }
 
         if ($error) {
         }
 
         if ($error) {

-            print $fh "type:error Update encountered errors.  Aborted\n";
+            print $fh "type:debug Update encountered errors.  Aborted\n";

             print $fh $last_poll;
         } else {
             print $fh $new_poll;
             print $fh $last_poll;
         } else {
             print $fh $new_poll;


@@ -659,17 +598,17 @@ sub do_updates {
     };
 
     if ($@) {
     };
 
     if ($@) {

-        print $fh "type:error Error during friends_timeline call.  Aborted.\n";
+        print $fh "type:debug Error during friends_timeline call.  Aborted.\n";

         return 1;
     }
 
     unless ( ref $tweets ) {
         if ( $obj->can("get_error") ) {
         return 1;
     }
 
     unless ( ref $tweets ) {
         if ( $obj->can("get_error") ) {

-            print $fh "type:error API Error during friends_timeline call: ",
+            print $fh "type:debug API Error during friends_timeline call: ",

               JSON::Any->jsonToObj( $obj->get_error() ), "  Aborted.\n";
         } else {
             print $fh
               JSON::Any->jsonToObj( $obj->get_error() ), "  Aborted.\n";
         } else {
             print $fh

-              "type:error API Error during friends_timeline call. Aborted.\n";
+              "type:debug API Error during friends_timeline call. Aborted.\n";

         }
         return 1;
     }
         }
         return 1;
     }


@@ -678,6 +617,7 @@ sub do_updates {
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;

+        $text =~ s/[\n\r]/ /g;

         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")
             and $t->{in_reply_to_screen_name} ne $username
         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")
             and $t->{in_reply_to_screen_name} ne $username


@@ -685,17 +625,25 @@ sub do_updates {
             and not exists $friends{ $t->{in_reply_to_screen_name} } )
         {
             $nicks{ $t->{in_reply_to_screen_name} } = time;
             and not exists $friends{ $t->{in_reply_to_screen_name} } )
         {
             $nicks{ $t->{in_reply_to_screen_name} } = time;

-            my $context = $obj->show_status( $t->{in_reply_to_status_id} );
+            my $context;
+            eval {
+                $context = $obj->show_status( $t->{in_reply_to_status_id} );
+            };
+

             if ($context) {
                 my $ctext = decode_entities( $context->{text} );
                 $ctext =~ s/%/%%/g;
                 $ctext =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;
             if ($context) {
                 my $ctext = decode_entities( $context->{text} );
                 $ctext =~ s/%/%%/g;
                 $ctext =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;

+                $ctext =~ s/[\n\r]/ /g;

                 printf $fh "id:%d account:%s nick:%s type:tweet %s\n",
                   $context->{id}, $username,
                   $context->{user}{screen_name}, $ctext;
                 $reply = "reply";
                 printf $fh "id:%d account:%s nick:%s type:tweet %s\n",
                   $context->{id}, $username,
                   $context->{user}{screen_name}, $ctext;
                 $reply = "reply";

+            } elsif ($@) {
+                print $fh "type:debug request to get context failed: $@";

             } else {
             } else {

-                print "Failed to get context from $t->{in_reply_to_screen_name}"
+                print $fh
+"type:debug Failed to get context from $t->{in_reply_to_screen_name}"

                   if &debug;
             }
         }
                   if &debug;
             }
         }


@@ -713,7 +661,7 @@ sub do_updates {
     };
 
     if ($@) {
     };
 
     if ($@) {

-        print $fh "type:error Error during replies call.  Aborted.\n";
+        print $fh "type:debug Error during replies call.  Aborted.\n";

         return 1;
     }
 
         return 1;
     }
 


@@ -724,6 +672,7 @@ sub do_updates {
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;

+        $text =~ s/[\n\r]/ /g;

         printf $fh "id:%d account:%s nick:%s type:tweet %s\n",
           $t->{id}, $username, $t->{user}{screen_name}, $text;
     }
         printf $fh "id:%d account:%s nick:%s type:tweet %s\n",
           $t->{id}, $username, $t->{user}{screen_name}, $text;
     }


@@ -736,7 +685,7 @@ sub do_updates {
     };
 
     if ($@) {
     };
 
     if ($@) {

-        print $fh "type:error Error during direct_messages call.  Aborted.\n";
+        print $fh "type:debug Error during direct_messages call.  Aborted.\n";

         return 1;
     }
 
         return 1;
     }
 


@@ -744,6 +693,7 @@ sub do_updates {
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
         $text =~ s/(^|\W)\@([-\w]+)/$1%B\@$2%n/g;

+        $text =~ s/[\n\r]/ /g;

         printf $fh "id:%d account:%s nick:%s type:dm %s\n",
           $t->{id}, $username, $t->{sender_screen_name}, $text;
     }
         printf $fh "id:%d account:%s nick:%s type:dm %s\n",
           $t->{id}, $username, $t->{sender_screen_name}, $text;
     }


@@ -768,7 +718,7 @@ sub monitor_child {
             my %meta;
             foreach my $key (qw/id account nick type/) {
                 if (s/^$key:(\S+)\s*//) {
             my %meta;
             foreach my $key (qw/id account nick type/) {
                 if (s/^$key:(\S+)\s*//) {

-                  $meta{$key} = $1;
+                    $meta{$key} = $1;

                 }
             }
 
                 }
             }
 


@@ -873,11 +823,70 @@ sub notice {
     $window->print( "%R***%n @_", MSGLEVEL_PUBLIC );
 }
 
     $window->print( "%R***%n @_", MSGLEVEL_PUBLIC );
 }
 

+sub update_away {
+    my $data = shift;
+
+    if (    Irssi::settings_get_bool("tweet_to_away")
+        and $data !~ /\@\w/
+        and $data !~ /^[dD] / )
+    {
+        my $server =
+          Irssi::server_find_tag( Irssi::settings_get_str("bitlbee_server") );
+        if ($server) {
+            $server->send_raw("away :$data");
+            return 1;
+        } else {
+            &notice( "Can't find bitlbee server.",
+                "Update bitlbee_server or disable tweet_to_away" );
+            return 0;
+        }
+    }
+
+    return 0;
+}
+
+sub too_long {
+    my $data = shift;
+
+    if ( length $data > 140 ) {
+        &notice(
+            "Tweet too long (" . length($data) . " characters) - aborted" );
+        return 1;
+    }
+
+    return 0;
+}
+
+sub valid_username {
+    my $username = shift;
+
+    unless ( exists $twits{$username} ) {
+        &notice("Unknown username $username");
+        return 0;
+    }
+
+    return 1;
+}
+
+sub logged_in {
+    my $obj = shift;
+    unless ($obj) {
+        &notice("Not logged in!  Use /twitter_login username pass!");
+        return 0;
+    }
+
+    return 1;
+}
+

 sub sig_complete {
     my ( $complist, $window, $word, $linestart, $want_space ) = @_;
 
 sub sig_complete {
     my ( $complist, $window, $word, $linestart, $want_space ) = @_;
 

-    # /twitter_reply gets a nick:num
-    if ( $linestart =~ /^\/twitter_reply(?:_as)?\s*$/ ) {
+    if (
+        $linestart =~ /^\/twitter_reply(?:_as)?\s*$/
+        or ( Irssi::settings_get_bool("twirssi_use_reply_aliases")
+            and $linestart =~ /^\/reply(?:_as)?\s*$/ )
+      )
+    {    # /twitter_reply gets a nick:num

         @$complist = grep /^\Q$word/i, sort keys %{ $id_map{__indexes} };
     }
 
         @$complist = grep /^\Q$word/i, sort keys %{ $id_map{__indexes} };
     }
 


@@ -901,12 +910,13 @@ Irssi::settings_add_str( "twirssi", "twitter_usernames", undef );
 Irssi::settings_add_str( "twirssi", "twitter_passwords", undef );
 Irssi::settings_add_str( "twirssi", "twirssi_replies_store",
     ".irssi/scripts/twirssi.json" );
 Irssi::settings_add_str( "twirssi", "twitter_passwords", undef );
 Irssi::settings_add_str( "twirssi", "twirssi_replies_store",
     ".irssi/scripts/twirssi.json" );

-Irssi::settings_add_bool( "twirssi", "tweet_to_away",         0 );
-Irssi::settings_add_bool( "twirssi", "show_reply_context",    0 );
-Irssi::settings_add_bool( "twirssi", "show_own_tweets",       1 );
-Irssi::settings_add_bool( "twirssi", "twirssi_debug",         0 );
-Irssi::settings_add_bool( "twirssi", "twirssi_first_run",     1 );
-Irssi::settings_add_bool( "twirssi", "twirssi_track_replies", 1 );
+Irssi::settings_add_bool( "twirssi", "tweet_to_away",             0 );
+Irssi::settings_add_bool( "twirssi", "show_reply_context",        0 );
+Irssi::settings_add_bool( "twirssi", "show_own_tweets",           1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_debug",             0 );
+Irssi::settings_add_bool( "twirssi", "twirssi_first_run",         1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_track_replies",     1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_use_reply_aliases", 0 );

 $window = Irssi::window_find_name( Irssi::settings_get_str('twitter_window') );
 
 if ($window) {
 $window = Irssi::window_find_name( Irssi::settings_get_str('twitter_window') );
 
 if ($window) {


@@ -920,6 +930,10 @@ if ($window) {
     Irssi::command_bind( "twitter_logout",   "cmd_logout" );
     Irssi::command_bind( "twitter_switch",   "cmd_switch" );
     Irssi::command_bind( "twirssi_upgrade",  "cmd_upgrade" );
     Irssi::command_bind( "twitter_logout",   "cmd_logout" );
     Irssi::command_bind( "twitter_switch",   "cmd_switch" );
     Irssi::command_bind( "twirssi_upgrade",  "cmd_upgrade" );

+    if ( Irssi::settings_get_bool("twirssi_use_reply_aliases") ) {
+        Irssi::command_bind( "reply",    "cmd_reply" );
+        Irssi::command_bind( "reply_as", "cmd_reply_as" );
+    }

     Irssi::command_bind(
         "twirssi_dump",
         sub {
     Irssi::command_bind(
         "twirssi_dump",
         sub {


@@ -934,9 +948,11 @@ if ($window) {
     Irssi::command_bind(
         "twirssi_version",
         sub {
     Irssi::command_bind(
         "twirssi_version",
         sub {

-            &notice(
-"Twirssi v$VERSION (r$REV);  Net::Twitter v$Net::Twitter::VERSION. "
-                  . "See details at http://tinyurl.com/twirssi" );
+            &notice("Twirssi v$VERSION (r$REV); "
+                  . "Net::Twitter v$Net::Twitter::VERSION. "
+                  . "JSON in use: "
+                  . JSON::Any::handler()
+                  . ".  See details at http://twirssi.com/" );

         }
     );
     Irssi::command_bind(
         }
     );
     Irssi::command_bind(