Print a helpful message when an SSL login fails.

[twirssi-net-twitter-lite.git] / twirssi.pl

diff --git a/twirssi.pl b/twirssi.pl
index 68dfac8d6c3fb2aea85e79d58e4cccb41a85bd34..92f60b6cbeb20eb3b7197a60a860f404b2d3e2ea 100644 (file)
--- a/twirssi.pl
+++ b/twirssi.pl
@@ -11,8 +11,8 @@ $Data::Dumper::Indent = 1;
 
 use vars qw($VERSION %IRSSI);
 
 
 use vars qw($VERSION %IRSSI);
 

-$VERSION = "2.2.5beta";
-my ($REV) = '$Rev: 676 $' =~ /(\d+)/;
+$VERSION = "2.2.6beta";
+my ($REV) = '$Rev: 687 $' =~ /(\d+)/;

 %IRSSI = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
 %IRSSI = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',


@@ -21,7 +21,7 @@ my ($REV) = '$Rev: 676 $' =~ /(\d+)/;
       . 'Can optionally set your bitlbee /away message to same',
     license => 'GNU GPL v2',
     url     => 'http://twirssi.com',
       . 'Can optionally set your bitlbee /away message to same',
     license => 'GNU GPL v2',
     url     => 'http://twirssi.com',

-    changed => '$Date: 2009-07-22 11:05:52 -0700 (Wed, 22 Jul 2009) $',
+    changed => '$Date: 2009-08-07 01:24:53 -0700 (Fri, 07 Aug 2009) $',

 );
 
 my $window;
 );
 
 my $window;


@@ -38,6 +38,7 @@ my %tweet_cache;
 my %id_map;
 my $failwhale  = 0;
 my $first_call = 1;
 my %id_map;
 my $failwhale  = 0;
 my $first_call = 1;

+my $child_pid;

 
 my %irssi_to_mirc_colors = (
     '%k' => '01',
 
 my %irssi_to_mirc_colors = (
     '%k' => '01',


@@ -495,9 +496,21 @@ sub cmd_login {
     $twit = "Net::$service"->new(
         username => $user,
         password => $pass,
     $twit = "Net::$service"->new(
         username => $user,
         password => $pass,

-        source   => "twirssi"
+        source   => "twirssi",
+        ssl      => Irssi::settings_get_bool("twirssi_avoid_ssl") ? 0 : 1,

     );
 
     );
 

+    unless ($twit) {
+        &notice("Failed to create Net::$service object!  Aborting.");
+        return;
+    }
+
+    if ( my $timeout = Irssi::settings_get_int("twitter_timeout")
+        and $twit->can('ua') )
+    {
+        $twit->ua->timeout($timeout);
+    }
+

     unless ( $twit->verify_credentials() ) {
         &notice("Login as $user\@$service failed");
         $twit = undef;
     unless ( $twit->verify_credentials() ) {
         &notice("Login as $user\@$service failed");
         $twit = undef;


@@ -537,6 +550,13 @@ sub cmd_login {
         return 1;
     } else {
         &notice("Login failed");
         return 1;
     } else {
         &notice("Login failed");

+        if ( not Irssi::settings_get_bool("twirssi_avoid_ssl") ) {
+            &notice(
+                "It's possible you're missing one of the modules required for "
+                  . "SSL logins.  Try setting twirssi_avoid_ssl to on.  See "
+                  . "http://cpansearch.perl.org/src/GAAS/libwww-perl-5.831/README.SSL "
+                  . "for the detailed requirements." );
+        }

     }
 }
 
     }
 }
 


@@ -764,13 +784,13 @@ sub get_updates {
 
     my ( $fh, $filename ) = File::Temp::tempfile();
     binmode( $fh, ":utf8" );
 
     my ( $fh, $filename ) = File::Temp::tempfile();
     binmode( $fh, ":utf8" );

-    my $pid = fork();
+    $child_pid = fork();

 
 

-    if ($pid) {    # parent
+    if ($child_pid) {    # parent

         Irssi::timeout_add_once( 5000, 'monitor_child',
             [ "$filename.done", 0 ] );
         Irssi::timeout_add_once( 5000, 'monitor_child',
             [ "$filename.done", 0 ] );

-        Irssi::pidwait_add($pid);
-    } elsif ( defined $pid ) {    # child
+        Irssi::pidwait_add($child_pid);
+    } elsif ( defined $child_pid ) {    # child

         close STDIN;
         close STDOUT;
         close STDERR;
         close STDIN;
         close STDOUT;
         close STDERR;


@@ -909,7 +929,9 @@ sub do_updates {
     printf $fh "id:%u account:%s type:last_id timeline\n",
       $new_poll_id, $username;
 
     printf $fh "id:%u account:%s type:last_id timeline\n",
       $new_poll_id, $username;
 

-    print scalar localtime, " - Polling for replies" if &debug;
+    print scalar localtime, " - Polling for replies since ",
+      $id_map{__last_id}{$username}{reply}
+      if &debug;

     $new_poll_id = 0;
     eval {
         if ( $id_map{__last_id}{$username}{reply} )
     $new_poll_id = 0;
     eval {
         if ( $id_map{__last_id}{$username}{reply} )


@@ -1031,6 +1053,7 @@ sub monitor_child {
     # pretend
 
     if ( open FILE, $filename ) {
     # pretend
 
     if ( open FILE, $filename ) {

+        binmode FILE, ":utf8";

         my @lines;
         my %new_cache;
         while (<FILE>) {
         my @lines;
         my %new_cache;
         while (<FILE>) {


@@ -1161,8 +1184,16 @@ sub monitor_child {
             }
 
             if (/^-- (\d+)$/) {
             }
 
             if (/^-- (\d+)$/) {

-                ($new_last_poll) = ($1);
-                last;
+                $new_last_poll = $1;
+                if ( $new_last_poll >= $last_poll ) {
+                    last;
+                } else {
+                    print "Impossible!  ",
+                      "new_last_poll=$new_last_poll < last_poll=$last_poll!"
+                      if &debug;
+                    undef $new_last_poll;
+                    next;
+                }

             }
             my ( $f, $t ) = split ' ', $_;
             $nicks{$f} = $friends{$f} = $t;
             }
             my ( $f, $t ) = split ' ', $_;
             $nicks{$f} = $friends{$f} = $t;


@@ -1200,6 +1231,9 @@ sub monitor_child {
             }
             $last_poll = $new_last_poll;
 
             }
             $last_poll = $new_last_poll;
 

+            # make sure the pid is removed from the waitpid list
+            Irssi::pidwait_remove($child_pid);
+

             # save id_map hash
             if ( keys %id_map
                 and my $file =
             # save id_map hash
             if ( keys %id_map
                 and my $file =


@@ -1499,6 +1533,7 @@ Irssi::settings_add_str( "twirssi", "twirssi_replies_store",
     ".irssi/scripts/twirssi.json" );
 
 Irssi::settings_add_int( "twirssi", "twitter_friends_poll", 600 );
     ".irssi/scripts/twirssi.json" );
 
 Irssi::settings_add_int( "twirssi", "twitter_friends_poll", 600 );

+Irssi::settings_add_int( "twirssi", "twitter_timeout",      30 );

 
 Irssi::settings_add_bool( "twirssi", "twirssi_upgrade_beta",      0 );
 Irssi::settings_add_bool( "twirssi", "tweet_to_away",             0 );
 
 Irssi::settings_add_bool( "twirssi", "twirssi_upgrade_beta",      0 );
 Irssi::settings_add_bool( "twirssi", "tweet_to_away",             0 );


@@ -1513,6 +1548,7 @@ Irssi::settings_add_bool( "twirssi", "twirssi_notify_timeouts",   1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_hilights",          1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_always_shorten",    0 );
 Irssi::settings_add_bool( "twirssi", "tweet_window_input",        0 );
 Irssi::settings_add_bool( "twirssi", "twirssi_hilights",          1 );
 Irssi::settings_add_bool( "twirssi", "twirssi_always_shorten",    0 );
 Irssi::settings_add_bool( "twirssi", "tweet_window_input",        0 );

+Irssi::settings_add_bool( "twirssi", "twirssi_avoid_ssl",         0 );

 
 $last_poll = time - &get_poll_time;
 $window = Irssi::window_find_name( Irssi::settings_get_str('twitter_window') );
 
 $last_poll = time - &get_poll_time;
 $window = Irssi::window_find_name( Irssi::settings_get_str('twitter_window') );


@@ -1569,11 +1605,22 @@ if ($window) {
     Irssi::command_bind(
         "twirssi_version",
         sub {
     Irssi::command_bind(
         "twirssi_version",
         sub {

-            &notice("Twirssi v$VERSION (r$REV); "
-                  . "Net::Twitter v$Net::Twitter::VERSION. "
+            &notice(
+                "Twirssi v$VERSION (r$REV); "
+                  . (
+                    $Net::Twitter::VERSION
+                    ? "Net::Twitter v$Net::Twitter::VERSION. "
+                    : ""
+                  )
+                  . (
+                    $Net::Identica::VERSION
+                    ? "Net::Identica v$Net::Identica::VERSION. "
+                    : ""
+                  )

                   . "JSON in use: "
                   . JSON::Any::handler()
                   . "JSON in use: "
                   . JSON::Any::handler()

-                  . ".  See details at http://twirssi.com/" );
+                  . ".  See details at http://twirssi.com/"
+            );

         }
     );
     Irssi::command_bind(
         }
     );
     Irssi::command_bind(


@@ -1600,6 +1647,22 @@ if ($window) {
             sub { &notice("Device updated to $_[0]"); }
         )
     );
             sub { &notice("Device updated to $_[0]"); }
         )
     );

+    Irssi::command_bind(
+        "twitter_block",
+        &gen_cmd(
+            "/twitter_block <username>",
+            "create_block",
+            sub { &notice("Blocked $_[0]"); }
+        )
+    );
+    Irssi::command_bind(
+        "twitter_unblock",
+        &gen_cmd(
+            "/twitter_unblock <username>",
+            "destroy_block",
+            sub { &notice("Unblock $_[0]"); }
+        )
+    );

     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 
     &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N (r$REV)");
     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 
     &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N (r$REV)");