Notice when a retweet command failed. Hack around longer retweets.

[twirssi-net-twitter-lite.git] / twirssi.pl

diff --git a/twirssi.pl b/twirssi.pl
index d894a36da1d1ff893d5b08ac26fd70bad24408d8..ee06ff6d7fe2c5f57a610b4d9d103323a42d7e12 100644 (file)
--- a/twirssi.pl
+++ b/twirssi.pl
@@ -11,9 +11,8 @@ $Data::Dumper::Indent = 1;
 
 use vars qw($VERSION %IRSSI);
 
 
 use vars qw($VERSION %IRSSI);
 

-$VERSION = "2.3.0beta";
-my ($REV) = '$Rev: 687 $' =~ /(\d+)/;
-%IRSSI = (
+$VERSION = "2.3.4beta";
+%IRSSI   = (

     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
     name        => 'twirssi',
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
     name        => 'twirssi',


@@ -91,7 +90,7 @@ sub cmd_direct_as {
         if ( $twits{$username}
             ->new_direct_message( { user => $target, text => $text } ) )
         {
         if ( $twits{$username}
             ->new_direct_message( { user => $target, text => $text } ) )
         {

-            &notice("DM sent to $target");
+            &notice("DM sent to $target: $text");

             $nicks{$target} = time;
         } else {
             my $error;
             $nicks{$target} = time;
         } else {
             my $error;


@@ -176,25 +175,28 @@ sub cmd_retweet_as {
     }
     $text =~ s/\$t/$id_map{__tweets}{ lc $nick }[$id]/;
 
     }
     $text =~ s/\$t/$id_map{__tweets}{ lc $nick }[$id]/;
 

+    my $modified = $data;

     $data = &shorten($text);
 
     $data = &shorten($text);
 

-    return if &too_long($data);
+    return if $modified and &too_long($data);

 
     my $success = 1;
     eval {
 
     my $success = 1;
     eval {

-        unless (
-            $twits{$username}->update(
+        if ($modified)
+        {
+            $success = $twits{$username}->update(

                 {
                     status => $data,
 
                     # in_reply_to_status_id => $id_map{ lc $nick }[$id]
                 }
                 {
                     status => $data,
 
                     # in_reply_to_status_id => $id_map{ lc $nick }[$id]
                 }

-            )
-          )
-        {
-            &notice("Update failed");
-            $success = 0;
+            );
+        } else {
+            $success =
+              $twits{$username}->retweet( { id => $id_map{ lc $nick }[$id] } );
+            $success = $success->{id} if ref $success;

         }
         }

+        &notice("Update failed") unless $success;

     };
     return unless $success;
 
     };
     return unless $success;
 


@@ -491,7 +493,7 @@ sub cmd_login {
     }
     $defservice = $service = ucfirst lc $service;
 
     }
     $defservice = $service = ucfirst lc $service;
 

-    eval "use Net::$service";
+    eval "use Net::$service 3.05";

     if ($@) {
         &notice(
             "Failed to load Net::$service when trying to log in as $user: $@");
     if ($@) {
         &notice(
             "Failed to load Net::$service when trying to log in as $user: $@");


@@ -514,6 +516,7 @@ sub cmd_login {
         and $twit->can('ua') )
     {
         $twit->ua->timeout($timeout);
         and $twit->can('ua') )
     {
         $twit->ua->timeout($timeout);

+        &notice("Twitter timeout set to $timeout");

     }
 
     unless ( $twit->verify_credentials() ) {
     }
 
     unless ( $twit->verify_credentials() ) {


@@ -699,9 +702,8 @@ sub cmd_upgrade {
 
     my $loc = Irssi::settings_get_str("twirssi_location");
     unless ( -w $loc ) {
 
     my $loc = Irssi::settings_get_str("twirssi_location");
     unless ( -w $loc ) {

-        &notice( "$loc isn't writable, can't upgrade." .
-                 "  Perhaps you need to /set twirssi_location?"
-        );
+        &notice("$loc isn't writable, can't upgrade."
+              . "  Perhaps you need to /set twirssi_location?" );

         return;
     }
 
         return;
     }
 


@@ -710,9 +712,8 @@ sub cmd_upgrade {
         eval { use Digest::MD5; };
 
         if ($@) {
         eval { use Digest::MD5; };
 
         if ($@) {

-            &notice( "Failed to load Digest::MD5." . 
-                     "  Try '/twirssi_upgrade nomd5' to skip MD5 verification"
-            );
+            &notice("Failed to load Digest::MD5."
+                  . "  Try '/twirssi_upgrade nomd5' to skip MD5 verification" );

             return;
         }
 
             return;
         }
 


@@ -725,8 +726,8 @@ sub cmd_upgrade {
         }
 
         unless ( open( CUR, $loc ) ) {
         }
 
         unless ( open( CUR, $loc ) ) {

-            &notice( "Failed to read $loc." .
-                     "  Check that /set twirssi_location is set to the correct location."
+            &notice("Failed to read $loc."
+                  . "  Check that /set twirssi_location is set to the correct location."

             );
             return;
         }
             );
             return;
         }


@@ -791,19 +792,27 @@ sub cmd_upgrade {
 }
 
 sub load_friends {
 }
 
 sub load_friends {

-    my $fh   = shift;
-    my $page = 1;
+    my $fh     = shift;
+    my $cursor = -1;
+    my $page   = 1;

     my %new_friends;
     eval {
     my %new_friends;
     eval {

-        while (1)
+        while ( $page < 11 and $cursor ne "0" )

         {
             print $fh "type:debug Loading friends page $page...\n"
               if ( $fh and &debug );
         {
             print $fh "type:debug Loading friends page $page...\n"
               if ( $fh and &debug );

-            my $friends = $twit->friends( { page => $page } );
-            last unless $friends;
+            my $friends;
+            if ( ref $twit =~ /^Net::Twitter/ ) {
+                $friends = $twit->friends( { cursor => $cursor } );
+                last unless $friends;
+                $cursor  = $friends->{next_cursor};
+                $friends = $friends->{users};
+            } else {
+                $friends = $twit->friends( { page => $page } );
+                last unless $friends;
+            }

             $new_friends{ $_->{screen_name} } = time foreach @$friends;
             $page++;
             $new_friends{ $_->{screen_name} } = time foreach @$friends;
             $page++;

-            last if @$friends == 0 or $page == 10;

         }
     };
 
         }
     };
 


@@ -876,7 +885,7 @@ sub get_updates {
                 $fix_replies_index{$_} = 0
                   if $fix_replies_index{$_} >= @frusers;
                 print $fh "id:$fix_replies_index{$_} ",
                 $fix_replies_index{$_} = 0
                   if $fix_replies_index{$_} >= @frusers;
                 print $fh "id:$fix_replies_index{$_} ",

-                          "account:$_ type:fix_replies_index\n";
+                  "account:$_ type:fix_replies_index\n";

             }
         }
 
             }
         }
 


@@ -930,14 +939,14 @@ sub do_updates {
     eval {
         if ( $id_map{__last_id}{$username}{timeline} )
         {
     eval {
         if ( $id_map{__last_id}{$username}{timeline} )
         {

-            $tweets = $obj->friends_timeline( { count => 100 } );
+            $tweets = $obj->home_timeline( { count => 100 } );

         } else {
         } else {

-            $tweets = $obj->friends_timeline();
+            $tweets = $obj->home_timeline();

         }
     };
 
     if ($@) {
         }
     };
 
     if ($@) {

-        print $fh "type:debug Error during friends_timeline call: Aborted.\n";
+        print $fh "type:debug Error during home_timeline call: Aborted.\n";

         print $fh "type:debug : $_\n" foreach split /\n/, Dumper($@);
         return undef;
     }
         print $fh "type:debug : $_\n" foreach split /\n/, Dumper($@);
         return undef;
     }


@@ -948,18 +957,19 @@ sub do_updates {
             eval { $error = JSON::Any->jsonToObj( $obj->get_error() ) };
             unless ($@) { $error = $obj->get_error() }
             print $fh
             eval { $error = JSON::Any->jsonToObj( $obj->get_error() ) };
             unless ($@) { $error = $obj->get_error() }
             print $fh

-              "type:debug API Error during friends_timeline call: Aborted\n";
+              "type:debug API Error during home_timeline call: Aborted\n";

             print $fh "type:debug : $_\n" foreach split /\n/, Dumper($error);
 
         } else {
             print $fh
             print $fh "type:debug : $_\n" foreach split /\n/, Dumper($error);
 
         } else {
             print $fh

-              "type:debug API Error during friends_timeline call. Aborted.\n";
+              "type:debug API Error during home_timeline call. Aborted.\n";

         }
         return undef;
     }
 
     foreach my $t ( reverse @$tweets ) {
         }
         return undef;
     }
 
     foreach my $t ( reverse @$tweets ) {

-        my $text = decode_entities( $t->{text} );
+        my $text =
+          decode_entities( $t->{retweeted_status}{text} || $t->{text} );

         $text =~ s/[\n\r]/ /g;
         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")
         $text =~ s/[\n\r]/ /g;
         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")


@@ -979,7 +989,9 @@ sub do_updates {
             $context = $cache->{ $t->{in_reply_to_status_id} };
 
             if ($context) {
             $context = $cache->{ $t->{in_reply_to_status_id} };
 
             if ($context) {

-                my $ctext = decode_entities( $context->{text} );
+                my $ctext =
+                  decode_entities( $context->{retweeted_status}{text}
+                      || $context->{text} );

                 $ctext =~ s/[\n\r]/ /g;
                 if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) {
                     $ctext .=
                 $ctext =~ s/[\n\r]/ /g;
                 if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) {
                     $ctext .=


@@ -1030,7 +1042,8 @@ sub do_updates {
         next
           if exists $friends{ $t->{user}{screen_name} };
 
         next
           if exists $friends{ $t->{user}{screen_name} };
 

-        my $text = decode_entities( $t->{text} );
+        my $text =
+          decode_entities( $t->{retweeted_status}{text} || $t->{text} );

         $text =~ s/[\n\r]/ /g;
         if ( $t->{truncated} ) {
             $text .= " -- http://twitter.com/$t->{user}{screen_name}"
         $text =~ s/[\n\r]/ /g;
         if ( $t->{truncated} ) {
             $text .= " -- http://twitter.com/$t->{user}{screen_name}"


@@ -1101,7 +1114,8 @@ sub do_updates {
               $search->{max_id}, $username, $topic;
 
             foreach my $t ( reverse @{ $search->{results} } ) {
               $search->{max_id}, $username, $topic;
 
             foreach my $t ( reverse @{ $search->{results} } ) {

-                my $text = decode_entities( $t->{text} );
+                my $text =
+                  decode_entities( $t->{retweeted_status}{text} || $t->{text} );

                 $text =~ s/[\n\r]/ /g;
                 printf $fh "id:%s account:%s nick:%s type:search topic:%s %s\n",
                   $t->{id}, $username, $t->{from_user}, $topic, $text;
                 $text =~ s/[\n\r]/ /g;
                 printf $fh "id:%s account:%s nick:%s type:search topic:%s %s\n",
                   $t->{id}, $username, $t->{from_user}, $topic, $text;


@@ -1122,16 +1136,14 @@ sub get_timeline {
     my $tweets;
     my $last_id = $id_map{__last_id}{$username}{$target};
 
     my $tweets;
     my $last_id = $id_map{__last_id}{$username}{$target};
 

-    print $fh "type:debug get_timeline(" .
-              "$fix_replies_index{$username}=$target > $last_id) started." .
-              "  username = $username\n";
+    print $fh "type:debug get_timeline("
+      . "$fix_replies_index{$username}=$target > $last_id) started."
+      . "  username = $username\n";

     eval {
         $tweets = $obj->user_timeline(
             {
                 id => $target,
     eval {
         $tweets = $obj->user_timeline(
             {
                 id => $target,

-                (   
-                    $last_id ? (since_id => $last_id) : ()
-                ),
+                ( $last_id ? ( since_id => $last_id ) : () ),

             }
         );
     };
             }
         );
     };


@@ -1150,7 +1162,8 @@ sub get_timeline {
     }
 
     foreach my $t ( reverse @$tweets ) {
     }
 
     foreach my $t ( reverse @$tweets ) {

-        my $text = decode_entities( $t->{text} );
+        my $text =
+          decode_entities( $t->{retweeted_status}{text} || $t->{text} );

         $text =~ s/[\n\r]/ /g;
         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")
         $text =~ s/[\n\r]/ /g;
         my $reply = "tweet";
         if (    Irssi::settings_get_bool("show_reply_context")


@@ -1170,7 +1183,9 @@ sub get_timeline {
             $context = $cache->{ $t->{in_reply_to_status_id} };
 
             if ($context) {
             $context = $cache->{ $t->{in_reply_to_status_id} };
 
             if ($context) {

-                my $ctext = decode_entities( $context->{text} );
+                my $ctext =
+                  decode_entities( $context->{retweeted_status}{text}
+                      || $context->{text} );

                 $ctext =~ s/[\n\r]/ /g;
                 if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) {
                     $ctext .=
                 $ctext =~ s/[\n\r]/ /g;
                 if ( $context->{truncated} and ref($obj) ne 'Net::Identica' ) {
                     $ctext .=


@@ -1192,7 +1207,7 @@ sub get_timeline {
         $last_id = $t->{id} if $last_id < $t->{id};
     }
     printf $fh "id:%s account:%s type:last_id_fixreplies %s\n",
         $last_id = $t->{id} if $last_id < $t->{id};
     }
     printf $fh "id:%s account:%s type:last_id_fixreplies %s\n",

-        $last_id, $username, $target;
+      $last_id, $username, $target;

 
     return 1;
 }
 
     return 1;
 }


@@ -1403,6 +1418,9 @@ sub monitor_child {
             # make sure the pid is removed from the waitpid list
             Irssi::pidwait_remove($child_pid);
 
             # make sure the pid is removed from the waitpid list
             Irssi::pidwait_remove($child_pid);
 

+            # and that we don't leave any zombies behind, somehow
+            wait();
+

             # save id_map hash
             if ( keys %id_map
                 and my $file =
             # save id_map hash
             if ( keys %id_map
                 and my $file =


@@ -1429,6 +1447,7 @@ sub monitor_child {
     } else {
         print "Giving up on polling $filename" if &debug;
         Irssi::pidwait_remove($child_pid);
     } else {
         print "Giving up on polling $filename" if &debug;
         Irssi::pidwait_remove($child_pid);

+        wait();

         unlink $filename unless &debug;
 
         return unless Irssi::settings_get_bool("twirssi_notify_timeouts");
         unlink $filename unless &debug;
 
         return unless Irssi::settings_get_bool("twirssi_notify_timeouts");


@@ -1550,7 +1569,9 @@ sub sig_complete {
           keys %{ $id_map{__indexes} };
     }
 
           keys %{ $id_map{__indexes} };
     }
 

-    if ( $linestart =~ /^\/(twitter_unfriend|twitter_add_follow_extra|twitter_del_follow_extra)\s*$/ )
+    if ( $linestart =~
+/^\/(twitter_unfriend|twitter_add_follow_extra|twitter_del_follow_extra)\s*$/
+      )

     {    # /twitter_unfriend gets a nick
         $word =~ s/^@//;
         push @$complist, grep /^\Q$word/i,
     {    # /twitter_unfriend gets a nick
         $word =~ s/^@//;
         push @$complist, grep /^\Q$word/i,


@@ -1593,7 +1614,7 @@ sub hilight {
     if ( Irssi::settings_get_str("twirssi_nick_color") ) {
         my $c = Irssi::settings_get_str("twirssi_nick_color");
         $c = $irssi_to_mirc_colors{$c};
     if ( Irssi::settings_get_str("twirssi_nick_color") ) {
         my $c = Irssi::settings_get_str("twirssi_nick_color");
         $c = $irssi_to_mirc_colors{$c};

-        $text =~ s/(^|\W)\@([-\w]+)/$1\cC$c\@$2\cO/g if $c;
+        $text =~ s/(^|\W)\@(\w+)/$1\cC$c\@$2\cO/g if $c;

     }
     if ( Irssi::settings_get_str("twirssi_topic_color") ) {
         my $c = Irssi::settings_get_str("twirssi_topic_color");
     }
     if ( Irssi::settings_get_str("twirssi_topic_color") ) {
         my $c = Irssi::settings_get_str("twirssi_topic_color");


@@ -1779,7 +1800,7 @@ if ($window) {
         "twirssi_version",
         sub {
             &notice(
         "twirssi_version",
         sub {
             &notice(

-                "Twirssi v$VERSION (r$REV); "
+                "Twirssi v$VERSION; "

                   . (
                     $Net::Twitter::VERSION
                     ? "Net::Twitter v$Net::Twitter::VERSION. "
                   . (
                     $Net::Twitter::VERSION
                     ? "Net::Twitter v$Net::Twitter::VERSION. "


@@ -1838,7 +1859,7 @@ if ($window) {
     );
     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 
     );
     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 

-    &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N (r$REV)");
+    &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N");

     &notice("   %C(_(\\%N           http://twirssi.com/ for full docs");
     &notice(
         "    %Y||%C `%N Log in with /twitter_login, send updates with /tweet");
     &notice("   %C(_(\\%N           http://twirssi.com/ for full docs");
     &notice(
         "    %Y||%C `%N Log in with /twitter_login, send updates with /tweet");