From: Jonathan McDowell <noodles@earth.li>
Date: Tue, 24 Mar 2009 20:47:43 +0000 (+0000)
Subject: Ensure DB4 backend dbconns memory is initialised to zero
X-Git-Url: https://git.sommitrealweird.co.uk/onak.git/commitdiff_plain/61b6fcfd1226b6540c151c902f8b688545494736?ds=sidebyside;hp=1a72b8d85895fc9ffba0d8f6a9240634ce6ee8dc

Ensure DB4 backend dbconns memory is initialised to zero

  Change to using calloc to allocate the memory for the dbconns array,
  as this will ensure that all the pointers in it are NULL which
  prevents us segfaulting on abnormal cleanup. Fixes the segfault from
  Debian bug #520117 but not the underlying issue.
---

diff --git a/keydb_db4.c b/keydb_db4.c
index e9dd509..8990758 100644
--- a/keydb_db4.c
+++ b/keydb_db4.c
@@ -314,7 +314,7 @@ static void db4_initdb(bool readonly)
 		}
 	}
 
-	dbconns = malloc(sizeof (DB *) * numdbs);
+	dbconns = calloc(numdbs, sizeof (DB *));
 	if (dbconns == NULL) {
 		logthing(LOGTHING_CRITICAL,
 				"Couldn't allocate memory for dbconns");