X-Git-Url: https://git.sommitrealweird.co.uk/onak.git/blobdiff_plain/4b8483ae278577a3adc8d84da81d77019704466f..3e6039189ef4130641633e0c8ea6cf2c75e6472f:/keyindex.c?ds=inline

diff --git a/keyindex.c b/keyindex.c
index 2c4e24c..5911cac 100644
--- a/keyindex.c
+++ b/keyindex.c
@@ -7,172 +7,52 @@
  */
 
 #include <assert.h>
+#include <inttypes.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
 
+#include "decodekey.h"
 #include "getcgi.h"
 #include "hash.h"
 #include "keydb.h"
 #include "keyid.h"
 #include "keyindex.h"
 #include "keystructs.h"
-#include "ll.h"
-#include "stats.h"
-
-int parse_subpackets(unsigned char *data, bool html)
-{
-	int offset = 0;
-	int length = 0;
-	int packetlen = 0;
-	char *uid;
-
-	assert(data != NULL);
-
-	length = (data[0] << 8) + data[1] + 2;
-
-	offset = 2;
-	while (offset < length) {
-		packetlen = data[offset++];
-		if (packetlen > 191 && packetlen < 255) {
-			packetlen = ((packetlen - 192) << 8) +
-					data[offset++] + 192;
-		} else if (packetlen == 255) {
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-		}
-		switch (data[offset]) {
-		case 2:
-			/*
-			 * Signature creation time. Might want to output this?
-			 */
-			break;
-		case 16:
-			uid = keyid2uid((data[offset+packetlen - 4] << 24) +
-	                                (data[offset+packetlen - 3] << 16) +
-	                                (data[offset+packetlen - 2] << 8) +
-	                                data[offset+packetlen - 1]);
-			if (html && uid != NULL) {
-				printf("sig        <a href=\"lookup?op=get&"
-					"search=%02X%02X%02X%02X\">"
-					"%02X%02X%02X%02X</a>             "
-					"<a href=\"lookup?op=vindex&"
-					"search=0x%02X%02X%02X%02X\">"
-					"%s</a>\n",
-					data[offset+packetlen - 4],
-					data[offset+packetlen - 3],
-					data[offset+packetlen - 2],
-					data[offset+packetlen - 1],
-					data[offset+packetlen - 4],
-					data[offset+packetlen - 3],
-					data[offset+packetlen - 2],
-					data[offset+packetlen - 1],
-
-					data[offset+packetlen - 4],
-					data[offset+packetlen - 3],
-					data[offset+packetlen - 2],
-					data[offset+packetlen - 1],
-					txt2html(uid));
-			} else if (html && uid == NULL) {
-				printf("sig        "
-					"%02X%02X%02X%02X             "
-					"[User id not found]\n",
-					data[offset+packetlen - 4],
-					data[offset+packetlen - 3],
-					data[offset+packetlen - 2],
-					data[offset+packetlen - 1]);
-			} else {
-				printf("sig        %02X%02X%02X%02X"
-						"             %s\n",
-					data[offset+packetlen - 4],
-					data[offset+packetlen - 3],
-					data[offset+packetlen - 2],
-					data[offset+packetlen - 1],
-					(uid != NULL) ? uid :
-					"[User id not found]");
-			}
-			break;
-		default:
-			/*
-			 * We don't care about unrecognized packets unless bit
-			 * 7 is set in which case we prefer an error than
-			 * ignoring it.
-			 */
-			assert(!(data[offset] & 0x80));
-		}
-		offset += packetlen;
-	}
-
-	return length;
-}
 
 int list_sigs(struct openpgp_packet_list *sigs, bool html)
 {
-	int length = 0;
-	char *uid;
+	char *uid = NULL;
+	uint64_t sigid = 0;
 
 	while (sigs != NULL) {
-		switch (sigs->packet->data[0]) {
-		case 2:
-		case 3:
-			uid = keyid2uid((sigs->packet->data[11] << 24) +
-	                                (sigs->packet->data[12] << 16) +
-	                                (sigs->packet->data[13] << 8) +
-	                                sigs->packet->data[14]);
-			if (html && uid != NULL) {
-				printf("sig        <a href=\"lookup?op=get&"
-					"search=%02X%02X%02X%02X\">"
-					"%02X%02X%02X%02X</a>             "
-					"<a href=\"lookup?op=vindex&"
-					"search=0x%02X%02X%02X%02X\">"
-					"%s</a>\n",
-					sigs->packet->data[11],
-					sigs->packet->data[12],
-					sigs->packet->data[13],
-					sigs->packet->data[14],
-					sigs->packet->data[11],
-					sigs->packet->data[12],
-					sigs->packet->data[13],
-					sigs->packet->data[14],
-
-					sigs->packet->data[11],
-					sigs->packet->data[12],
-					sigs->packet->data[13],
-					sigs->packet->data[14],
-					txt2html(uid));
-			} else if (html && uid == NULL) {
-				printf("sig        %02X%02X%02X%02X"
-					"             "
-					"[User id not found]\n",
-					sigs->packet->data[11],
-					sigs->packet->data[12],
-					sigs->packet->data[13],
-					sigs->packet->data[14]);
-			} else {
-				printf("sig        %02X%02X%02X%02X"
-						"             %s\n",
-					sigs->packet->data[11],
-					sigs->packet->data[12],
-					sigs->packet->data[13],
-					sigs->packet->data[14],
-					(uid != NULL) ? uid :
-					"[User id not found]");
-			}
-			break;
-		case 4:
-			length = parse_subpackets(&sigs->packet->data[4], html);
-			parse_subpackets(&sigs->packet->data[length + 4], html);
-			break;
-		default:
-			printf("sig        [Unknown packet version %d]",
-					sigs->packet->data[0]);
+		sigid = sig_keyid(sigs->packet);
+		uid = keyid2uid(sigid);
+		if (html && uid != NULL) {
+			printf("sig         <a href=\"lookup?op=get&"
+				"search=%08llX\">%08llX</a>             "
+				"<a href=\"lookup?op=vindex&search=0x%08llX\">"
+				"%s</a>\n",
+				sigid & 0xFFFFFFFF,
+				sigid & 0xFFFFFFFF,
+				sigid & 0xFFFFFFFF,
+				txt2html(uid));
+		} else if (html && uid == NULL) {
+			printf("sig         %08llX             "
+				"[User id not found]\n",
+				sigid & 0xFFFFFFFF);
+		} else {
+			printf("sig         %08llX"
+				"             %s\n",
+				sigid & 0xFFFFFFFF,
+				(uid != NULL) ? uid :
+				"[User id not found]");
+		}
+		if (uid != NULL) {
+			free(uid);
+			uid = NULL;
 		}
 		sigs = sigs->next;
 	}
@@ -189,10 +69,10 @@ int list_uids(struct openpgp_signedpacket_list *uids, bool verbose, bool html)
 			snprintf(buf, 1023, "%.*s",
 				(int) uids->packet->length,
 				uids->packet->data);
-			printf("uid                            %s\n",
+			printf("uid                             %s\n",
 				(html) ? txt2html(buf) : buf);
 		} else if (uids->packet->tag == 17) {
-			printf("uid                            "
+			printf("uid                             "
 				"[photo id]\n");
 		}
 		if (verbose) {
@@ -204,6 +84,60 @@ int list_uids(struct openpgp_signedpacket_list *uids, bool verbose, bool html)
 	return 0;
 }
 
+int list_subkeys(struct openpgp_signedpacket_list *subkeys, bool verbose,
+		bool html)
+{
+	struct tm	*created = NULL;
+	time_t		created_time = 0;
+	int	 	type = 0;
+	int	 	length = 0;
+
+	while (subkeys != NULL) {
+		if (subkeys->packet->tag == 14) {
+
+			created_time = (subkeys->packet->data[1] << 24) +
+					(subkeys->packet->data[2] << 16) +
+					(subkeys->packet->data[3] << 8) +
+					subkeys->packet->data[4];
+			created = gmtime(&created_time);
+
+			switch (subkeys->packet->data[0]) {
+			case 2:
+			case 3:
+				type = subkeys->packet->data[7];
+				length = (subkeys->packet->data[8] << 8) +
+					subkeys->packet->data[9];
+				break;
+			case 4:
+				type = subkeys->packet->data[5];
+				length = (subkeys->packet->data[6] << 8) +
+					subkeys->packet->data[7];
+				break;
+			default:
+				fprintf(stderr, "Unknown key type: %d\n",
+					subkeys->packet->data[0]);
+			}
+		
+			printf("sub  %5d%c/%08X %04d/%02d/%02d\n",
+				length,
+				(type == 1) ? 'R' : ((type == 16) ? 'g' : 
+					((type == 17) ? 'D' : '?')),
+				(uint32_t) (get_packetid(subkeys->packet) &
+					    0xFFFFFFFF),
+				created->tm_year + 1900,
+				created->tm_mon + 1,
+				created->tm_mday);
+
+		}
+		if (verbose) {
+			list_sigs(subkeys->sigs, html);
+		}
+		subkeys = subkeys->next;
+	}
+
+	return 0;
+}
+
 /**
  *	key_index - List a set of OpenPGP keys.
  *	@keys: The keys to display.
@@ -227,7 +161,7 @@ int key_index(struct openpgp_publickey *keys, bool verbose, bool fingerprint,
 	if (html) {
 		puts("<pre>");
 	}
-	puts("Type  bits/keyID    Date       User ID");
+	puts("Type   bits/keyID    Date       User ID");
 	while (keys != NULL) {
 		created_time = (keys->publickey->data[1] << 24) +
 					(keys->publickey->data[2] << 16) +
@@ -252,9 +186,10 @@ int key_index(struct openpgp_publickey *keys, bool verbose, bool fingerprint,
 				keys->publickey->data[0]);
 		}
 		
-		printf("pub  %4d%c/%08X %04d/%02d/%02d ",
+		printf("pub  %5d%c/%08X %04d/%02d/%02d ",
 			length,
-			(type == 1) ? 'R' : ((type == 17) ? 'D' : '?'),
+			(type == 1) ? 'R' : ((type == 16) ? 'g' : 
+				((type == 17) ? 'D' : '?')),
 			(uint32_t) (get_keyid(keys) & 0xFFFFFFFF),
 			created->tm_year + 1900,
 			created->tm_mon + 1,
@@ -267,7 +202,6 @@ int key_index(struct openpgp_publickey *keys, bool verbose, bool fingerprint,
 				curuid->packet->data);
 			printf("%s\n", (html) ? txt2html(buf) : buf);
 			if (verbose) {
-
 				list_sigs(curuid->sigs, html);
 			}
 			curuid = curuid->next;
@@ -276,8 +210,7 @@ int key_index(struct openpgp_publickey *keys, bool verbose, bool fingerprint,
 		}
 
 		list_uids(curuid, verbose, html);
-
-		//TODO: List subkeys.
+		list_subkeys(keys->subkeys, verbose, html);
 
 		keys = keys->next;
 	}
@@ -288,101 +221,3 @@ int key_index(struct openpgp_publickey *keys, bool verbose, bool fingerprint,
 
 	return 0;
 }
-
-
-int get_subpackets_keyid(unsigned char *data, uint64_t *keyid)
-{
-	int offset = 0;
-	int length = 0;
-	int packetlen = 0;
-
-	assert(data != NULL);
-
-	length = (data[0] << 8) + data[1] + 2;
-
-	offset = 2;
-	while (offset < length) {
-		packetlen = data[offset++];
-		if (packetlen > 191 && packetlen < 255) {
-			packetlen = ((packetlen - 192) << 8) +
-					data[offset++] + 192;
-		} else if (packetlen == 255) {
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-			packetlen <<= 8;
-			packetlen = data[offset++];
-		}
-		switch (data[offset]) {
-		case 2:
-			/*
-			 * Signature creation time. Might want to output this?
-			 */
-			break;
-		case 16:
-			*keyid = (data[offset+packetlen - 4] << 24) +
-				(data[offset+packetlen - 3] << 16) +
-				(data[offset+packetlen - 2] << 8) +
-				data[offset+packetlen - 1];
-			*keyid &= 0xFFFFFFFF;
-			break;
-		default:
-			/*
-			 * We don't care about unrecognized packets unless bit
-			 * 7 is set in which case we prefer an error than
-			 * ignoring it.
-			 */
-			assert(!(data[offset] & 0x80));
-		}
-		offset += packetlen;
-	}
-
-	return length;
-}
-
-
-/**
- *	keysigs - Return the sigs on a given OpenPGP signature list.
- *	@curll: The current linked list. Can be NULL to create a new list.
- *	@sigs: The signature list we want the sigs on.
- *
- *	Returns a linked list of stats_key elements containing the sigs on the
- *	supplied OpenPGP packet list.
- */
-struct ll *keysigs(struct ll *curll,
-		struct openpgp_packet_list *sigs)
-{
-	int length = 0;
-	uint64_t keyid = 0;
-	
-	while (sigs != NULL) {
-		keyid = 0;
-		switch (sigs->packet->data[0]) {
-		case 2:
-		case 3:
-			keyid = sigs->packet->data[11] << 24;
-			keyid += (sigs->packet->data[12] << 16);
-			keyid += (sigs->packet->data[13] << 8);
-			keyid += sigs->packet->data[14];
-			keyid &= 0xFFFFFFFF;
-			break;
-		case 4:
-			length = get_subpackets_keyid(&sigs->packet->data[4],
-					&keyid);
-			get_subpackets_keyid(&sigs->packet->data[length + 4],
-					&keyid);
-			/*
-			 * Don't bother to look at the unsigned packets.
-			 */
-			break;
-		default:
-			break;
-		}
-		sigs = sigs->next;
-		curll = lladd(curll, createandaddtohash(keyid));
-	}
-
-	return curll;
-}