X-Git-Url: https://git.sommitrealweird.co.uk/eoc.git/blobdiff_plain/747343e09d2930ebc783f9cc657a87877e823fb8..2fd44f9ecd58a7a3fb9ff56ae4bce6125142cef5:/eoc.py diff --git a/eoc.py b/eoc.py index 52621bc..3400d65 100644 --- a/eoc.py +++ b/eoc.py @@ -395,13 +395,21 @@ class MailingListManager: "\n ".join(text[:text.find("\n\n")].split("\n")))) if recipients: if self.smtp_server: - smtp = smtplib.SMTP(self.smtp_server) - smtp.sendmail(envelope_sender, recipients, text) - smtp.quit() + try: + smtp = smtplib.SMTP(self.smtp_server) + smtp.sendmail(envelope_sender, recipients, text) + smtp.quit() + except: + error("Error sending SMTP mail, mail probably not sent") + sys.exit(1) elif self.qmqp_server: - q = qmqp.QMQP(self.qmqp_server) - q.sendmail(envelope_sender, recipients, text) - q.quit() + try: + q = qmqp.QMQP(self.qmqp_server) + q.sendmail(envelope_sender, recipients, text) + q.quit() + except: + error("Error sending QMQP mail, mail probably not sent") + sys.exit(1) else: recipients = string.join(recipients, " ") f = os.popen("%s -oi -f '%s' %s" % @@ -410,7 +418,11 @@ class MailingListManager: recipients), "w") f.write(text) - f.close() + status = f.close() + if status != 0: + error("%s returned %d, mail sending probably failed" % + (self.sendmail, status)) + sys.exit((status >> 8) & 0xff) else: debug("send_mail: no recipients, not sending") @@ -892,6 +904,10 @@ class MailingList: return text + self.template("footer", {}) def send_mail_to_subscribers(self, text): + text = self.remove_some_headers(text, ["list-id", "list-help", + "list-unsubscribe", + "list-subscribe", "list-post", + "list-owner", "precedence"]) text = self.headers_to_add() + self.list_headers() + \ self.headers_to_remove(text) text = self.append_footer(text)