X-Git-Url: https://git.sommitrealweird.co.uk//gitweb/?p=twirssi-net-twitter-lite.git;a=blobdiff_plain;f=twirssi.pl;h=b049e6f77433f90b45d279f724febc2db8c16773;hp=94ed5541e2a22fc43b7d138fec7980f9691f8656;hb=62cf981acdfe8406aec3e17d7ef4e56dea5cd15d;hpb=1e8a35098ef53f648b15d7409fb83810e1f2358b

diff --git a/twirssi.pl b/twirssi.pl
index 94ed554..b049e6f 100644
--- a/twirssi.pl
+++ b/twirssi.pl
@@ -11,8 +11,8 @@ $Data::Dumper::Indent = 1;
 
 use vars qw($VERSION %IRSSI);
 
-$VERSION = "1.5.3";
-my ($REV) = '$Rev: 333 $' =~ /(\d+)/;
+$VERSION = "1.7";
+my ($REV) = '$Rev: 344 $' =~ /(\d+)/;
 %IRSSI = (
     authors     => 'Dan Boger',
     contact     => 'zigdon@gmail.com',
@@ -21,7 +21,7 @@ my ($REV) = '$Rev: 333 $' =~ /(\d+)/;
       . 'Can optionally set your bitlbee /away message to same',
     license => 'GNU GPL v2',
     url     => 'http://tinyurl.com/twirssi',
-    changed => 'Mon Dec  1 15:36:01 PST 2008',
+    changed => '$Date: 2009-01-05 16:40:46 -0800 (Mon, 05 Jan 2009) $',
 );
 
 my $window;
@@ -71,10 +71,17 @@ sub cmd_direct_as {
         return;
     }
 
-    unless ( $twits{$username}
-        ->new_direct_message( { user => $target, text => $text } ) )
-    {
-        &notice("DM to $target failed");
+    eval {
+        unless ( $twits{$username}
+            ->new_direct_message( { user => $target, text => $text } ) )
+        {
+            &notice("DM to $target failed");
+            return;
+        }
+    };
+
+    if ($@) {
+        &notice("DM caused an error.  Aborted");
         return;
     }
 
@@ -135,8 +142,144 @@ sub cmd_tweet_as {
         return;
     }
 
-    unless ( $twits{$username}->update($data) ) {
-        &notice("Update failed");
+    eval {
+        unless ( $twits{$username}->update($data) )
+        {
+            &notice("Update failed");
+            return;
+        }
+    };
+
+    if ($@) {
+        &notice("Update caused an error.  Aborted.");
+        return;
+    }
+
+    foreach ( $data =~ /@([-\w]+)/ ) {
+        $nicks{$1} = time;
+    }
+
+    my $away = 0;
+    if (    Irssi::settings_get_bool("tweet_to_away")
+        and $data !~ /\@\w/
+        and $data !~ /^[dD] / )
+    {
+        my $server =
+          Irssi::server_find_tag( Irssi::settings_get_str("bitlbee_server") );
+        if ($server) {
+            $server->send_raw("away :$data");
+            $away = 1;
+        } else {
+            &notice( "Can't find bitlbee server.",
+                "Update bitlbee_server or disalbe tweet_to_away" );
+        }
+    }
+
+    &notice( "Update sent" . ( $away ? " (and away msg set)" : "" ) );
+}
+
+sub cmd_reply {
+    my ( $data, $server, $win ) = @_;
+
+    unless ($twit) {
+        &notice("Not logged in!  Use /twitter_login username pass!");
+        return;
+    }
+
+    $data =~ s/^\s+|\s+$//;
+    unless ($data) {
+        &notice("Usage: /reply <nick[:num]> <update>");
+        return;
+    }
+
+    $data =~ s/^\s+|\s+$//;
+    my ( $id, $data ) = split ' ', $data, 2;
+    unless ( $id and $data ) {
+        &notice("Usage: /reply_as <nick[:num]> <update>");
+        return;
+    }
+
+    &cmd_reply_as( "$user $id $data", $server, $win );
+}
+
+sub cmd_reply_as {
+    my ( $data, $server, $win ) = @_;
+
+    unless ( Irssi::settings_get_bool("twirssi_track_replies") ) {
+        &notice("twirssi_track_replies is required in order to reply to "
+              . "specific tweets.  Either enable it, or just use /tweet "
+              . "\@username <text>." );
+        return;
+    }
+
+    unless ($twit) {
+        &notice("Not logged in!  Use /twitter_login username pass!");
+        return;
+    }
+
+    $data =~ s/^\s+|\s+$//;
+    my ( $username, $id, $data ) = split ' ', $data, 3;
+
+    unless ( $username and $data ) {
+        &notice("Usage: /reply_as <username> <nick[:num]> <update>");
+        return;
+    }
+
+    unless ( exists $twits{$username} ) {
+        &notice("Unknown username $username");
+        return;
+    }
+
+    my $nick;
+    $id =~ s/[^\w\d\-:]+//g;
+    ( $nick, $id ) = split /:/, $id;
+    unless ( exists $id_map{$nick} ) {
+        &notice("Can't find a tweet from $nick to reply to!");
+        return;
+    }
+
+    $id = $id_map{__indexes}{$nick} unless $id;
+    unless ( $id_map{ lc $nick }[$id] ) {
+        &notice("Can't find a tweet numbered $id from $nick to reply to!");
+        return;
+    }
+
+    # remove any @nick at the beginning of the reply, as we'll add it anyway
+    $data =~ s/^\s*\@?$nick\s*//;
+    $data = "\@$nick " . $data;
+
+    if ( Irssi::settings_get_str("short_url_provider") ) {
+        foreach my $url ( $data =~ /(https?:\/\/\S+[\w\/])/g ) {
+            eval {
+                my $short = makeashorterlink($url);
+                $data =~ s/\Q$url/$short/g;
+            };
+        }
+    }
+
+    if ( length $data > 140 ) {
+        &notice(
+            "Tweet too long (" . length($data) . " characters) - aborted" );
+        return;
+    }
+
+    eval {
+        unless (
+            $twits{$username}->update(
+                {
+                    status                => $data,
+                    in_reply_to_status_id => $id_map{ lc $nick }[$id]
+                }
+            )
+          )
+        {
+            &notice("Update failed");
+            return;
+        }
+    };
+
+    if ($@) {
+        &notice("Update caused an error.  Aborted");
         return;
     }
 
@@ -180,8 +323,16 @@ sub gen_cmd {
             return;
         }
 
-        unless ( $twit->$api_name($data) ) {
-            &notice("$api_name failed");
+        eval {
+            unless ( $twit->$api_name($data) )
+            {
+                &notice("$api_name failed");
+                return;
+            }
+        };
+
+        if ($@) {
+            &notice("$api_name caused an error.  Aborted.");
             return;
         }
 
@@ -396,34 +547,42 @@ sub cmd_upgrade {
 }
 
 sub load_friends {
-    my $fh = shift;
+    my $fh   = shift;
     my $page = 1;
     my %new_friends;
-    while (1) {
-        print $fh "Loading friends page $page...\n" if ($fh and &debug);
-        my $friends = $twit->friends( { page => $page } );
-        last unless $friends;
-        $new_friends{ $_->{screen_name} } = time foreach @$friends;
-        $page++;
-        last if @$friends == 0 or $page == 10;
+    eval {
+        while (1)
+        {
+            print $fh "Loading friends page $page...\n" if ( $fh and &debug );
+            my $friends = $twit->friends( { page => $page } );
+            last unless $friends;
+            $new_friends{ $_->{screen_name} } = time foreach @$friends;
+            $page++;
+            last if @$friends == 0 or $page == 10;
+        }
+    };
+
+    if ($@) {
+        &notice("Error during friends list update.  Aborted.");
+        return;
     }
 
-    my ($added, $removed) = (0, 0);
-    print $fh "Scanning for new friends...\n" if ($fh and &debug);
+    my ( $added, $removed ) = ( 0, 0 );
+    print $fh "Scanning for new friends...\n" if ( $fh and &debug );
     foreach ( keys %new_friends ) {
         next if exists $friends{$_};
         $friends{$_} = time;
         $added++;
     }
 
-    print $fh "Scanning for removed friends...\n" if ($fh and &debug);
+    print $fh "Scanning for removed friends...\n" if ( $fh and &debug );
     foreach ( keys %friends ) {
         next if exists $new_friends{$_};
-        delete $friends{$_}; 
+        delete $friends{$_};
         $removed++;
     }
 
-    return ($added, $removed);
+    return ( $added, $removed );
 }
 
 sub get_updates {
@@ -446,7 +605,7 @@ sub get_updates {
     my $pid = fork();
 
     if ($pid) {    # parent
-        Irssi::timeout_add_once( 5000, 'monitor_child', [$filename] );
+        Irssi::timeout_add_once( 5000, 'monitor_child', [ $filename, 0 ] );
         Irssi::pidwait_add($pid);
     } elsif ( defined $pid ) {    # child
         close STDIN;
@@ -455,23 +614,32 @@ sub get_updates {
 
         my $new_poll = time;
 
-        &do_updates( $fh, $user, $twit );
+        my $error = 0;
+        $error += &do_updates( $fh, $user, $twit );
         foreach ( keys %twits ) {
             next if $_ eq $user;
-            &do_updates( $fh, $_, $twits{$_} );
+            $error += &do_updates( $fh, $_, $twits{$_} );
         }
 
-        my ($added, $removed) = &load_friends($fh);
-        if ($added + $removed) {
-          print $fh "%R***%n Friends list updated: ",
-                    join(", ", sprintf("%d added", $added),
-                               sprintf("%d removed", $removed)), "\n";
+        my ( $added, $removed ) = &load_friends($fh);
+        if ( $added + $removed ) {
+            print $fh "%R***%n Friends list updated: ",
+              join( ", ",
+                sprintf( "%d added",   $added ),
+                sprintf( "%d removed", $removed ) ),
+              "\n";
         }
         print $fh "__friends__\n";
         foreach ( sort keys %friends ) {
             print $fh "$_ $friends{$_}\n";
         }
-        print $fh $new_poll;
+
+        if ($error) {
+            print $fh "type:error Update encountered errors.  Aborted\n";
+            print $fh $last_poll;
+        } else {
+            print $fh $new_poll;
+        }
         close $fh;
         exit;
     }
@@ -482,9 +650,18 @@ sub do_updates {
     my ( $fh, $username, $obj ) = @_;
 
     print scalar localtime, " - Polling for updates for $username" if &debug;
-    my $tweets =
-      $obj->friends_timeline( { since => HTTP::Date::time2str($last_poll) } )
-      || [];
+    my $tweets;
+    eval {
+        $tweets = $obj->friends_timeline(
+            { since => HTTP::Date::time2str($last_poll) } )
+          || [];
+    };
+
+    if ($@) {
+        print $fh "type:error Error during friends_timeline call.  Aborted.\n";
+        return 1;
+    }
+
     foreach my $t ( reverse @$tweets ) {
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
@@ -518,8 +695,16 @@ sub do_updates {
     }
 
     print scalar localtime, " - Polling for replies" if &debug;
-    $tweets = $obj->replies( { since => HTTP::Date::time2str($last_poll) } )
-      || [];
+    eval {
+        $tweets = $obj->replies( { since => HTTP::Date::time2str($last_poll) } )
+          || [];
+    };
+
+    if ($@) {
+        print $fh "type:error Error during replies call.  Aborted.\n";
+        return 1;
+    }
+
     foreach my $t ( reverse @$tweets ) {
         next
           if exists $friends{ $t->{user}{screen_name} };
@@ -532,9 +717,17 @@ sub do_updates {
     }
 
     print scalar localtime, " - Polling for DMs" if &debug;
-    $tweets =
-      $obj->direct_messages( { since => HTTP::Date::time2str($last_poll) } )
-      || [];
+    eval {
+        $tweets =
+          $obj->direct_messages( { since => HTTP::Date::time2str($last_poll) } )
+          || [];
+    };
+
+    if ($@) {
+        print $fh "type:error Error during direct_messages call.  Aborted.\n";
+        return 1;
+    }
+
     foreach my $t ( reverse @$tweets ) {
         my $text = decode_entities( $t->{text} );
         $text =~ s/%/%%/g;
@@ -543,10 +736,12 @@ sub do_updates {
           $t->{id}, $username, $t->{sender_screen_name}, $text;
     }
     print scalar localtime, " - Done" if &debug;
+
+    return 0;
 }
 
 sub monitor_child {
-    my $data     = shift;
+    my ( $data, $attempt ) = @_;
     my $filename = $data->[0];
 
     print scalar localtime, " - checking child log at $filename" if &debug;
@@ -558,24 +753,39 @@ sub monitor_child {
             last if /^__friends__/;
             my %meta;
             foreach my $key (qw/id account nick type/) {
-              s/^$key:(\S+)\s*//;
-              $meta{$key} = $1;
+                s/^$key:(\S+)\s*//;
+                $meta{$key} = $1;
             }
 
-            next if exists $tweet_cache{$meta{id}};
-            $tweet_cache{$meta{id}} = time;
+            next if exists $tweet_cache{ $meta{id} };
+            $tweet_cache{ $meta{id} } = time;
             my $account = "";
-            if ($meta{account} ne $user) {
-              $account = "$meta{account}: ";
+            if ( $meta{account} ne $user ) {
+                $account = "$meta{account}: ";
             }
-            if ($meta{type} eq 'tweet') {
-              push @lines, "[$account%B\@$meta{nick}%n] $_\n",
-            } elsif ($meta{type} eq 'reply') {
-              push @lines, "[$account\\--> %B\@$meta{nick}%n] $_\n",
-            } elsif ($meta{type} eq 'dm') {
-              push @lines, "[$account%B\@$meta{nick}%n (%%WDM%%n)] $_\n",
-            } elsif ($meta{type} eq 'debug') {
-              push @lines, "debug: $_\n" if &debug,
+
+            my $marker = "";
+            if (    $meta{type} ne 'dm'
+                and Irssi::settings_get_bool("twirssi_track_replies")
+                and $meta{nick}
+                and $meta{id} )
+            {
+                $marker = ( $id_map{__indexes}{ $meta{nick} } + 1 ) % 100;
+                $id_map{ lc $meta{nick} }[$marker] = $meta{id};
+                $id_map{__indexes}{ $meta{nick} }  = $marker;
+                $marker                            = ":$marker";
+            }
+
+            if ( $meta{type} eq 'tweet' ) {
+                push @lines, "[$account%B\@$meta{nick}%n$marker] $_\n",;
+            } elsif ( $meta{type} eq 'reply' ) {
+                push @lines, "[$account\\--> %B\@$meta{nick}%n$marker] $_\n",;
+            } elsif ( $meta{type} eq 'dm' ) {
+                push @lines, "[$account%B\@$meta{nick}%n (%WDM%n)] $_\n",;
+            } elsif ( $meta{type} eq 'error' ) {
+                push @lines, "debug: $_\n" if &debug,;
+            } elsif ( $meta{type} eq 'debug' ) {
+                push @lines, "debug: $_\n" if &debug,;
             }
         }
 
@@ -604,17 +814,37 @@ sub monitor_child {
               or warn "Failed to remove $filename: $!"
               unless &debug;
 
-      # keep 10 minutes of cached tweets, to make sure we don't show duplicates.
+            # keep enough cached tweets, to make sure we don't show duplicates.
             foreach ( keys %tweet_cache ) {
-                next if $tweet_cache{$_} > time - 600;
+                next if $tweet_cache{$_} >= $old_last_poll;
                 delete $tweet_cache{$_};
             }
+
+            # save id_map hash
+            if ( keys %id_map
+                and my $file =
+                Irssi::settings_get_str("twirssi_replies_store") )
+            {
+                if ( open JSON, ">$file" ) {
+                    print JSON JSON::Any->objToJson( \%id_map );
+                    close JSON;
+                } else {
+                    &notice("Failed to write replies to $file: $!");
+                }
+            }
             return;
         }
     }
 
     close FILE;
-    Irssi::timeout_add_once( 5000, 'monitor_child', [$filename] );
+
+    if ( $attempt < 12 ) {
+        Irssi::timeout_add_once( 5000, 'monitor_child',
+            [ $filename, $attempt + 1 ] );
+    } else {
+        &notice("Giving up on polling $filename");
+        unlink $filename unless &debug;
+    }
 }
 
 sub debug {
@@ -628,12 +858,24 @@ sub notice {
 sub sig_complete {
     my ( $complist, $window, $word, $linestart, $want_space ) = @_;
 
-    return unless $linestart =~ /^\/(?:tweet|dm)/;
-    my $prefix = $word =~ s/^@//;
-    $prefix = 0 if $linestart eq '/dm' or $linestart eq '/dm_as';
-    push @$complist, grep /^\Q$word/i,
-      sort { $nicks{$b} <=> $nicks{$a} } keys %nicks;
-    @$complist = map { "\@$_" } @$complist if $prefix;
+    if (
+        $linestart =~ /^\/twitter_reply(?:_as)?\s*$/
+        or ( Irssi::settings_get_bool("twirssi_use_reply_aliases")
+            and $linestart =~ /^\/reply(?:_as)?\s*$/ )
+      )
+    {    # /twitter_reply gets a nick:num
+        @$complist = grep /^\Q$word/i, sort keys %{ $id_map{__indexes} };
+    }
+
+    # /tweet, /tweet_as, /dm, /dm_as - complete @nicks (and nicks as the first
+    # arg to dm)
+    if ( $linestart =~ /^\/(?:tweet|dm)/ ) {
+        my $prefix = $word =~ s/^@//;
+        $prefix = 0 if $linestart eq '/dm' or $linestart eq '/dm_as';
+        push @$complist, grep /^\Q$word/i,
+          sort { $nicks{$b} <=> $nicks{$a} } keys %nicks;
+        @$complist = map { "\@$_" } @$complist if $prefix;
+    }
 }
 
 Irssi::settings_add_str( "twirssi", "twitter_window",     "twitter" );
@@ -643,28 +885,40 @@ Irssi::settings_add_str( "twirssi", "twirssi_location",
     ".irssi/scripts/twirssi.pl" );
 Irssi::settings_add_str( "twirssi", "twitter_usernames", undef );
 Irssi::settings_add_str( "twirssi", "twitter_passwords", undef );
-Irssi::settings_add_bool( "twirssi", "tweet_to_away",      0 );
-Irssi::settings_add_bool( "twirssi", "show_reply_context", 0 );
-Irssi::settings_add_bool( "twirssi", "show_own_tweets",    1 );
-Irssi::settings_add_bool( "twirssi", "twirssi_debug",      0 );
-Irssi::settings_add_bool( "twirssi", "twirssi_first_run",  1 );
+Irssi::settings_add_str( "twirssi", "twirssi_replies_store",
+    ".irssi/scripts/twirssi.json" );
+Irssi::settings_add_bool( "twirssi", "tweet_to_away",             0 );
+Irssi::settings_add_bool( "twirssi", "show_reply_context",        0 );
+Irssi::settings_add_bool( "twirssi", "show_own_tweets",           1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_debug",             0 );
+Irssi::settings_add_bool( "twirssi", "twirssi_first_run",         1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_track_replies",     1 );
+Irssi::settings_add_bool( "twirssi", "twirssi_use_reply_aliases", 0 );
 $window = Irssi::window_find_name( Irssi::settings_get_str('twitter_window') );
 
 if ($window) {
-    Irssi::command_bind( "dm",              "cmd_direct" );
-    Irssi::command_bind( "tweet",           "cmd_tweet" );
-    Irssi::command_bind( "dm_as",           "cmd_direct_as" );
-    Irssi::command_bind( "tweet_as",        "cmd_tweet_as" );
-    Irssi::command_bind( "twitter_login",   "cmd_login" );
-    Irssi::command_bind( "twitter_logout",  "cmd_logout" );
-    Irssi::command_bind( "twitter_switch",  "cmd_switch" );
-    Irssi::command_bind( "twirssi_upgrade", "cmd_upgrade" );
+    Irssi::command_bind( "dm",               "cmd_direct" );
+    Irssi::command_bind( "dm_as",            "cmd_direct_as" );
+    Irssi::command_bind( "tweet",            "cmd_tweet" );
+    Irssi::command_bind( "tweet_as",         "cmd_tweet_as" );
+    Irssi::command_bind( "twitter_reply",    "cmd_reply" );
+    Irssi::command_bind( "twitter_reply_as", "cmd_reply_as" );
+    Irssi::command_bind( "twitter_login",    "cmd_login" );
+    Irssi::command_bind( "twitter_logout",   "cmd_logout" );
+    Irssi::command_bind( "twitter_switch",   "cmd_switch" );
+    Irssi::command_bind( "twirssi_upgrade",  "cmd_upgrade" );
+    if ( Irssi::settings_get_bool("twirssi_use_reply_aliases") ) {
+        Irssi::command_bind( "reply",    "cmd_reply" );
+        Irssi::command_bind( "reply_as", "cmd_reply_as" );
+    }
     Irssi::command_bind(
-        "twitter_dump",
+        "twirssi_dump",
         sub {
-            print "twits: ",   Dumper \%twits;
+            print "twits: ", join ", ",
+              map { "u: $_->{username}" } values %twits;
             print "friends: ", join ", ", sort keys %friends;
             print "nicks: ",   join ", ", sort keys %nicks;
+            print "id_map: ", Dumper \%{ $id_map{__indexes} };
             print "last poll: $last_poll";
         }
     );
@@ -696,10 +950,28 @@ if ($window) {
     Irssi::signal_add_last( 'complete word' => \&sig_complete );
 
     &notice("  %Y<%C(%B^%C)%N                   TWIRSSI v%R$VERSION%N (r$REV)");
-    &notice("   %C(_(\\%N        http://twirssi.com/ for full docs");
+    &notice("   %C(_(\\%N           http://twirssi.com/ for full docs");
     &notice(
         "    %Y||%C `%N Log in with /twitter_login, send updates with /tweet");
 
+    my $file = Irssi::settings_get_str("twirssi_replies_store");
+    if ( $file and -r $file ) {
+        if ( open( JSON, $file ) ) {
+            local $/;
+            my $json = <JSON>;
+            close JSON;
+            eval {
+                my $ref = JSON::Any->jsonToObj($json);
+                %id_map = %$ref;
+                my $num = keys %{ $id_map{__indexes} };
+                &notice( sprintf "Loaded old replies from %d contact%s.",
+                    $num, ( $num == 1 ? "" : "s" ) );
+            };
+        } else {
+            &notice("Failed to load old replies from $file: $!");
+        }
+    }
+
     if ( my $provider = Irssi::settings_get_str("short_url_provider") ) {
         eval "use WWW::Shorten::$provider;";